https://bugzilla.redhat.com/show_bug.cgi?id=1938451 Petr Menšík <pemensik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |pemensik@xxxxxxxxxx --- Comment #8 from Petr Menšík <pemensik@xxxxxxxxxx> --- Thanks for licenses fixed. Correct me if I am wrong, but sextractor is already packaged for Fedora [1]. Astrometry seems to exist as well [2]. Therefore just bundled(astronomy) should not be used, unless sources bundled in this package are modified and incompatible with last versions. If they are compatible, libraries should be used. Starting with BuildRequires: astrometry-devel Any downstream changes required to build with shared library astronomy should be reported back to upstream. There exists also python-sep package [3], which seems to package only python part of sep library. It seems a new package sep should be imported, providing both python and C-library, which can be then used both to provide python package and sep-devel library for reuse by this package. Until that is finished, I guess Provides: bundled(sep) is acceptable. It should be noted in spec as TODO, maybe even fill a bug on python-sep for missing C library for coordination. Ideally new review bug should be created for sep, this bug depending on it. Otherwise spec looks ready. From quick look to CMakeLists.txt, upstream does not even consider astrometry separate library. Can you try to build it using shared libraries with existing packages? I have seen astrometry.cfg in sources. Should it also Recommends: astrometry, at least? 1. https://src.fedoraproject.org/rpms/sextractor 2. https://src.fedoraproject.org/rpms/astrometry 3. https://src.fedoraproject.org/rpms/python-sep -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
