https://bugzilla.redhat.com/show_bug.cgi?id=1969450 --- Comment #3 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> --- (In reply to Katerina Koukiou from comment #2) > (In reply to Robert-André Mauchin 🐧 from comment #1) > > - the git info version should only be in Releases not Version; > > > > Version: 1.5 > > > > - Where does the 1.5 come from? I only see 1 in the tagged releases. > > Fixed upstream with > https://github.com/skobyda/cockpit-certificates/pull/56/commits/ > 93e2b4196f840bdc89e2a6ffc0c627f544f3c8b8 > > > > > - The Release tag is weird, it should be something like; > > > > Release: 1.20210608gitgccba50c%{?dist} > > This was just added by packit [1] because the build was generated from a PR, > not a real release > > Release: 1%{?dist} > > is the original: > https://github.com/skobyda/cockpit-certificates/blob/master/cockpit- > certificates.spec.in#L3 > > > > > - This should either be a URL, or you should add a comment explaining how > > the tarball was generated; > > > > Source0: cockpit-certificates-1.5.gccba50c.tar.gz > > I use packit [1] which creates a COPR build for each PR. To create the > tarball packit runs the command as specified in the configuration file here: > https://github.com/skobyda/cockpit-certificates/blob/master/packit.yml#L11 > > `make dist-gzip` > > Running this command will generate the above tarball. Add the command as a comment above the archive. > > The original cockpit-certificates.spec.in has the link to the github release > artifact as seen here: > https://github.com/skobyda/cockpit-certificates/blob/master/cockpit- > certificates.spec.in#L8 > > [1] https://packit.dev/ > > > > > - You can't ship the js already minified, you must provide the unminified > > versions and then minify them in the build section > > > > See > > https://docs.fedoraproject.org/en-US/packaging-guidelines/JavaScript/ > > #_compilationminification > > > > That will not work. Building requires internet access, npm install, etc., > which is not allowed in package builds. > (note that we do the same in cockpit, cockpit-ostree, cockpit-podman, > cockpit-machines, see for example > https://src.fedoraproject.org/rpms/cockpit-machines/blob/rawhide/f/cockpit- > machines.spec) > That's why you predownload the node_modules amd cockpit lib in separate archives as shown in the SPEC file I provided you. The build script must be run within the SPEC. > Also, keep in mind cockpit-* packages are not JS libs for other packages to > consume, rather JS apps. > > > - The license field should represent all the bundled JS too > > > > - BuildRequires: libappstream-glib is included twice > > > > Fixed upstream: > https://github.com/skobyda/cockpit-certificates/pull/56/commits/ > b694e7562627474c6a39b3d75e120a9d28a717fa > -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
