https://bugzilla.redhat.com/show_bug.cgi?id=1967876 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 addresses are Ok. Source0 archive (SHA-512: 6523c0e44b53835796c5b3f41cb6281413b79c596601a1971b8cb6fc7b2c76fc53ca60642bc96897083d6504ffc0e5ed35b475df4e9264231a5d602d90b3dd35) is original. Ok. Summary verified from lib/Statistics/ChiSquare.pm. Ok. Description verified from lib/Statistics/ChiSquare.pm. Ok. License verified from lib/Statistics/ChiSquare.pm. FIXME: Add "and CC-BY-SA" to the License tag (lib/Statistics/ChiSquare.pm:447). TODO: "make %{?_smp_mflags}" and "make pure_install" invocation can be replacved with "%{make_build}" and "%{make_install}" if "perl Makefile.PL" is augmented. No XS code, noarch Build is Ok. Build-type dependencies are Ok. All tests pass. Ok. $ rpmlint perl-Statistics-ChiSquare.spec ../SRPMS/perl-Statistics-ChiSquare-1.0000-1.fc35.src.rpm ../RPMS/noarch/perl-Statistics-ChiSquare-1.0000-1.fc35.noarch.rpm ========================================================== rpmlint session starts ========================================================= rpmlint: 2.0.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 3 =========================== 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.4 s ========================== rpmlint is Ok. rpm -q -lv -p ../RPMS/noarch/perl-Statistics-ChiSquare-1.0000-1.fc35.noarch.rpm drwxr-xr-x 2 root root 0 Jun 11 12:31 /usr/share/doc/perl-Statistics-ChiSquare -rw-r--r-- 1 root root 514 Oct 21 2016 /usr/share/doc/perl-Statistics-ChiSquare/CHANGELOG -rw-r--r-- 1 root root 265 Jul 23 2011 /usr/share/doc/perl-Statistics-ChiSquare/README drwxr-xr-x 2 root root 0 Jun 11 12:31 /usr/share/licenses/perl-Statistics-ChiSquare -rw-r--r-- 1 root root 6111 Sep 19 2013 /usr/share/licenses/perl-Statistics-ChiSquare/ARTISTIC.txt -rw-r--r-- 1 root root 17987 Sep 19 2013 /usr/share/licenses/perl-Statistics-ChiSquare/GPL2.txt -rw-r--r-- 1 root root 3344 Jun 11 12:31 /usr/share/man/man3/Statistics::ChiSquare.3pm.gz drwxr-xr-x 2 root root 0 Jun 11 12:31 /usr/share/perl5/vendor_perl/Statistics -rw-r--r-- 1 root root 42967 Oct 21 2016 /usr/share/perl5/vendor_perl/Statistics/ChiSquare.pm The file permissions and layout are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Statistics-ChiSquare-1.0000-1.fc35.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.34.0) 1 perl(Exporter) 1 perl(strict) 1 perl(vars) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Statistics-ChiSquare-1.0000-1.fc35.noarch.rpm | sort -f | uniq -c 1 perl(Statistics::ChiSquare) = 1.0000 1 perl-Statistics-ChiSquare = 1.0000-1.fc35 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Statistics-ChiSquare-1.0000-1.fc35.noarch.rpm Binary dependencies are resolvable. Ok. The package builds in F35 (https://koji.fedoraproject.org/koji/taskinfo?taskID=69848542). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct the FIX item and consider fixing the TODO item before building this package. Resolution: Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
