https://bugzilla.redhat.com/show_bug.cgi?id=1967774 Major Hayden <mhayden@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(code@musicinmybra | |in.net) --- Comment #15 from Major Hayden <mhayden@xxxxxxxxxx> --- (In reply to Ben Beasley from comment #13) > ===== Notes ===== > > - You have replaced %{python3_pkgversion} with “3”. Great for Fedora, and, I > think, OK for EPEL8 > too. Okay, good. That was one of your suggestions from the reviews above and it simplifies things a little. > - You have switched to %forge… macros to reference source, and are using > them correctly. 🎉 > - You added “%global distprefix %{nil}” to keep snapshot versioning from > being applied to the > dist tag as a result of using “%global tag …” with the %forge… macros > (which you had to do > because the normal release style assumes tags look like “v%{version}” but > this package just > uses “%{version}”). This is OK, I think, although I tend to leave it alone > and just let the > %forge… macros do their thing. > > Just don’t forget to stop overriding distprefix if you later have to set > “%global commit …” > instead. Thanks! I will keep that in mind if I switch from tags/releases to commits (which I hope I don't have to do anytime soon). 😉 > - You have added a doc package. Great! It looks sane. It correctly installs > the license file, > too. 🥳 > ===== Issues ===== > > - You added duplicate BuildRequires for the unbundled dependencies under > python3-fabric, > rather than adding Requires, so the runtime Requires are still incomplete. Fixed. Spec URL: https://download.copr.fedorainfracloud.org/results/mhayden/azure-cli/fedora-rawhide-x86_64/02241394-python-fabric/python-fabric.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/mhayden/azure-cli/fedora-rawhide-x86_64/02241394-python-fabric/python-fabric-2.6.0-1.fc35.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
