https://bugzilla.redhat.com/show_bug.cgi?id=1967774 Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(code@musicinmybra |needinfo?(mhayden@xxxxxxxxx |in.net) |m) --- Comment #13 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- I’m just going to review the diff between this and the previous spec file. ===== Notes ===== - You have replaced %{python3_pkgversion} with “3”. Great for Fedora, and, I think, OK for EPEL8 too. - You have switched to %forge… macros to reference source, and are using them correctly. - You added “%global distprefix %{nil}” to keep snapshot versioning from being applied to the dist tag as a result of using “%global tag …” with the %forge… macros (which you had to do because the normal release style assumes tags look like “v%{version}” but this package just uses “%{version}”). This is OK, I think, although I tend to leave it alone and just let the %forge… macros do their thing. Just don’t forget to stop overriding distprefix if you later have to set “%global commit …” instead. - You have added a doc package. Great! It looks sane. It correctly installs the license file, too. ===== Issues ===== - You added duplicate BuildRequires for the unbundled dependencies under python3-fabric, rather than adding Requires, so the runtime Requires are still incomplete. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
