Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: R-rlecuyer - R interface to RNG with multiple streams https://bugzilla.redhat.com/show_bug.cgi?id=248692 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tibbs@xxxxxxxxxxx Status|NEW |ASSIGNED Flag| |fedora-review+ ------- Additional Comments From tibbs@xxxxxxxxxxx 2007-11-18 20:52 EST ------- This package is fine; the only thing I can see is that you don't need the manual R dependency for arch-specific R packages because rpm will find the libR.so dependency on its own. * source files match upstream: 94aaeb5fb7b164223fc71f3d9813ce5a75c88cf7ff18521ab6012a5039511f9f rlecuyer_0.1.tar.gz * package meets naming and versioning guidelines. * package follows R packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly * debuginfo package looks complete. * rpmlint has only the expected complaints. * final provides and requires are sane (extraneous R dependency): rlecuyer.so()(64bit) R-rlecuyer = 0.1-2.fc9 = /bin/sh ? R libR.so()(64bit) * %check is present and all tests pass. * no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no static libraries. * no libtool .la files. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review