https://bugzilla.redhat.com/show_bug.cgi?id=1968655 --- Comment #1 from Carl George 🤠 <carl@xxxxxxxxxx> --- cmake_modules/Findhidapi.cmake is licensed under Boost Software License 1.0, so the license tag needs to be updated and a comment added to explain the license breakdown [0]. -License: GPLv3+ +# The entire source code is GPLv3+ except cmake_modules/Findhidapi.cmake which is Boost +License: GPLv3+ and Boost The current Source0 URL will create a tarball filename with just the version. It should also include the name [1]. -Source0: %{url}/archive/%{version}/%{version}.tar.gz +Source0: %{url}/archive/%{version}/%{name}-%{version}.tar.gz Despite the Boost licensed file mentioned earlier, upstream is missing the Boost license file in their repository. That license requires itself be included in all copies of the software [2]. You'll need to file an issue upstream asking them to correct this, and in the meantime add the license as an additional source in the spec [3]. You should also include a link to the upstream issue as a comment right before this source. +# https://github.com/Sapd/HeadsetControl/issues/XXX +Source1: https://www.boost.org/LICENSE_1_0.txt The requires on hidapi is unnecessary, when built the package is built it gets an automatic requires on the relevant library soname [4]. -Requires: hidapi Related to the Boost license issue, copy it to the build directory during %prep (after %setup), otherwise the %license macro in %files won't be able to pick it up. +cp %{SOURCE1} license.boost There is no need to create and use a build directory in %build and %install, the cmake macros handle that for you [5]. %build -mkdir build -pushd build -%cmake .. +%cmake %cmake_build %install -pushd build %cmake_install Upstream runs a test suite in their CI. We should run the same thing in a %check section [6]. +%check +%ctest In %files you should use %{_bindir} instead of a hard coded directory name [7]. -/usr/bin/headsetcontrol +%{_bindir}/headsetcontrol Also in %files, include the boost license file we added above. -%license license +%license license license.boost [0] https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_multiple_licensing_scenarios [1] https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_git_tags [2] https://www.boost.org/LICENSE_1_0.txt [3] https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text [4] https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_requires [5] https://docs.fedoraproject.org/en-US/packaging-guidelines/CMake/#_example_usage_in_the_spec_file [6] https://docs.fedoraproject.org/en-US/packaging-guidelines/#_test_suites [7] https://docs.fedoraproject.org/en-US/packaging-guidelines/#_macros -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
