Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: R-BufferedMatrixMethods - Microarray Data related methods that utlize BufferedMatrix https://bugzilla.redhat.com/show_bug.cgi?id=247699 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From tibbs@xxxxxxxxxxx 2007-11-18 19:46 EST ------- Now, to this ticket: Builds fine and has only the two expected rpmlint complaints. There are a few minor issues with the dependencies: You don't need the explicit Requires: R; rpm will dinf the libR.so dependency for you. You don't need a build dependency on R-BufferedMatrix because R-BufferedMatrix-devel will bring it in anyway. You should normally have a build depencency on R-devel, although it's not an absolute requirement as this package manages to build without it. Normally you'd have a dependency on tetex-latex. I thought it was required to build the documentation and the %check section will warn about not finding it, but I can't see any substantive difference between builds with and without it, so I guess there's no need for it. None of these are blockers. * source files match upstream: d01fac28ee6c314bb8a0c9d4501acf38e47a1047b76117d16323d56bbe1ef9a2 BufferedMatrixMethods_1.0.0.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly * debuginfo package looks complete. * rpmlint has only the usual complaints. * final provides and requires are sane: BufferedMatrixMethods.so()(64bit) R-BufferedMatrixMethods = 1.0.0-5.fc9 = /bin/sh R R-BufferedMatrix libR.so()(64bit) * %check is present and all tests pass. * no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * scriptlets are OK (R index generation) * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no static libraries. * no libtool .la files. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review