https://bugzilla.redhat.com/show_bug.cgi?id=1968139 --- Comment #2 from Jan Drögehoff <sentrycraft123@xxxxxxxxx> --- (In reply to Robert-André Mauchin 🐧 from comment #1) > - Can't this be unbundled? Zig includes parts of these projects for itself, its standard library and cross compilation support Here is a breakdown on where what is used: - compiler-rt is used within the standard library and has been ported to zig https://github.com/ziglang/zig/tree/masterlib/std/special/compiler_rt - glibc, mingw and musl have their header files bundled for cross compilation and in the case for glibc it also keeps track of ABI changes and functions https://github.com/ziglang/zig/tree/master/lib/libc/ - libcxx is included for C++ cross compilation https://github.com/ziglang/zig/tree/master/lib/libcxx - libunwind is included for debugging https://github.com/ziglang/zig/blob/master/lib/libunwind > - Use ExclusiveArch instead I had initially followed https://fedoraproject.org/wiki/Architectures#ExcludeArch_.26_ExclusiveArch but considering zig has a well defined list of supported systems that is probably for the better > - I would recommend creating a RPM macro file with a zig_arches macro to use in future zig package. Maybe also a zig_build and zig_install if necessary. Zigs build system is rather ambigious but I went and made one anyways it didn't allow specifying the lib suffix so I went and created a patch that allows specifying absolute paths to the lib dir, bin dir and include dir that are in the process of being upstreamed https://github.com/ziglang/zig/pull/9020 > - Where are the tests: Test were removed but in retrospect it would have probably been better to comment them out with a reason why Right now the non rawhide tests are affected by https://bugs.llvm.org/show_bug.cgi?id=49401 https://github.com/ziglang/zig/issues/8130 and the rawhide builds don't compile because of an unsupported glibc version > - The man pages extension shouldn't be globbed as the compression may > change: Fair point, changed Spec URL: https://pagure.io/zig-spec/blob/fedora2/f/zig.spec SRPM URL: https://releases.pagure.org/zig-spec/zig-0.8.0-1.fc34.src1.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
