https://bugzilla.redhat.com/show_bug.cgi?id=1966722 --- Comment #7 from Major Hayden <mhayden@xxxxxxxxxx> --- (In reply to Ben Beasley from comment #6) > Looks great. Package approved, with a few comments below. > > Package Review > ============== > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > > ===== Notes (no change required) ===== > > - This is not really required: > > %{?!python3_pkgversion:%global python3_pkgversion 3} > > since the macro is already defined to “3” on Fedora and EPEL8 (and to “36” > on > EPEL7). There should not be any current Fedora or EPEL release where it is > undefined. > > It might be possible to dispense with the macro entirely and use just a > literal “3”, if you are not targeting EPEL7. It is not clear to me if there > is any reason to use the macro in EPEL8 or not. > > (If you are targeting EPEL7, you will need a few tweaks to get > there—mostly, > manual Requires guarded by “%if 0%{?el7}/%endif”, > “%if 0%{?epel} == 7/%endif”, or similar, since EPEL7 lacks a Python > dependency generator.) I see. Thanks for that! > - You can, if you like, write > > %{python3_sitelib}/knack-*.egg-info > > as > > %{python3_sitelib}/knack-py%{python3_version}.egg-info > > or > > %{python3_sitelib}/%{srcname}-py%{python3_version}.egg-info > > which works as a boilerplate pattern for most simple Python packages, but > the > version you have is fine. Good to know. I always like re-using variables whenever I can. Thank you! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
