https://bugzilla.redhat.com/show_bug.cgi?id=1966722 Major Hayden <mhayden@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(mhayden@xxxxxxxxx | |m) | --- Comment #3 from Major Hayden <mhayden@xxxxxxxxxx> --- (In reply to Ben Beasley from comment #2) > - The patch for https://fedoraproject.org/wiki/Changes/DeprecatePythonMock > looks reasonable: > > # Use unittest's mock that is built in for Python 3.x. > sed -i 's/^import mock/from unittest import mock/' tests/*.py > > but it should be offered upstream. I went ahead and created a PR, which you > can link in a comment: > > # https://github.com/microsoft/knack/pull/248 > Thanks! Noted that in the spec. > Because you are using pyproject-rpm-macros (a great idea!) I know you are > targeting only Fedora, not EPEL7 or EPEL8, since the pyproject-rpm-macros are > not available there. Considering that: Good point. I'd like this to potentially work in EPEL, so I'll go back to the other python RPM macros instead. > - You should remove > > %{?python_enable_dependency_generator} Done. Spec URL: https://download.copr.fedorainfracloud.org/results/mhayden/python-knack/fedora-rawhide-x86_64/02222348-python-knack/python-knack.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/mhayden/python-knack/fedora-rawhide-x86_64/02222348-python-knack/python-knack-0.8.2-1.fc35.src.rpm fedora-review: https://copr-be.cloud.fedoraproject.org/results/mhayden/python-knack/fedora-rawhide-x86_64/02222348-python-knack/fedora-review/review.txt -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
