https://bugzilla.redhat.com/show_bug.cgi?id=1965111 --- Comment #6 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> --- You've failed to address any of these comments: (In reply to Robert-André Mauchin 🐧 from comment #2) > - It is preferred to split the BR one per line: > > BuildRequires: boost-thread > BuildRequires: boost-system > BuildRequires: boost-date-time > BuildRequires: boost-serialization > BuildRequires: CGAL-devel > BuildRequires: cmake > BuildRequires: gcc-c++ > BuildRequires: gmp-devel > BuildRequires: mpfr-devel > > - Are you sure you need > > BuildRequires: boost-thread > BuildRequires: boost-system > BuildRequires: boost-date-time > BuildRequires: boost-serialization > > at build time? Shouldn't your BR boost-devel instead? > > - This shouldn't be in the description: > > Note: W: shared-lib-calls-exit /usr/lib64/libSFCGAL.so.1.3.8 exit@GLIBC_2.2.5 > > - In order to avoid unintentional and unannounced soname bump, we recommend > not globbing the major soname version, be more specific instead: > > %{_libdir}/libSFCGAL.so.1* > > My tiny laptop is gonna suffer for the rest of the review. (In reply to Robert-André Mauchin 🐧 from comment #3) > That wasn't that bad. > > - There is no test: > > + /usr/bin/ctest --output-on-failure --force-new-ctest-process -j16 > Test project /builddir/build/BUILD/SFCGAL-v1.3.10/x86_64-redhat-linux-gnu > No tests were found!!! > > You thus can drop %check > > - Consider sending a patch upstream to fix this: > > wrong-file-end-of-line-encoding > /usr/share/doc/SFCGAL-devel/example/CGAL-polygon_triangulation2/main.cpp > > -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
