[Bug 1965672] Review Request: heroic-games-launcher - Heroic is an Open Source Game Launcher for Linux

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1965672

Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zebob.m@xxxxxxxxx



--- Comment #3 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> ---
 - Provides: bundled(libffmpeg)

This is not allowed. ffmpeg is covered by patents which makes it not
packageable in Fedora. FFMPEG is packaged in RPMFusion instead. If you want to
package it, propose it to RPMFusion.

Also, requiring internet access during build is not ok, it is not available in
Koji.


 - You would need to unbundle all of this:

Provides: bundled(libffmpeg)
Provides: bundled(libEGL)
Provides: bundled(libGLESv2)
Provides: bundled(libvk_swiftshader)


 - Generally, electron apps are not packaged in Fedora due to the huge mess it
is.

 - Atim packaged it in
https://copr.fedorainfracloud.org/coprs/atim/heroic-games-launcher/package/heroic-games-launcher-bin/
based off the official RPM package, so not bothering with electron in its spec.
However since it includes FFMPEG, it is not allowed in COPR too.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux