https://bugzilla.redhat.com/show_bug.cgi?id=1964682 Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx Doc Type|--- |If docs needed, set a value Flags|needinfo? | |needinfo?(package-review@li | |sts.fedoraproject.org) | --- Comment #1 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> --- - Group: Development/Tools Group is not used in Fedora - License: Eclipse Distribution License 1.0 and Eclipse Public License 1.0 This is not valid, we use shorthand for the licenses, check the valid ones at https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses License: BSD and EPL-1.0 - Requires: openssl Requires: paho-c >= 1.3.1 These should be autodetected. - Use a more explicit name for your archive: Source: https://github.com/eclipse/paho.mqtt.cpp/archive/v%{version}/%{name}-%{version}.tar.gz - Latest version is 1.2.0 - Please add a comment justifying why that patch is needed: Patch0: paho1.1_logremove.patch It does not seem necessary anymore with 1.2.0 - Licenses must be installed with %license not %doc: %license edl-v10 epl-v10 - Requires: paho-cpp Almost ok but read this https://docs.fedoraproject.org/en-US/packaging-guidelines/#_requiring_base_package Thus is should be: Requires: %{name}%{?_isa} = %{version}-%{release} - You create a devel-docs package but do not assign any files to it in %files section. There should be a: %files devel-docs %license edl-v10 epl-v10 %doc %{_docdir}/%{name}/samples/ %doc %{_docdir}/%{name}/html/ - Not needed: mkdir build.paho.cpp && cd build.paho.cpp The %cmake macro already does something similar. So use: %build %cmake -DPAHO_WITH_SSL=TRUE -DPAHO_BUILD_DOCUMENTATION=TRUE %cmake_build %install %cmake_install - Add CHANGELOG.md CONTRIBUTING.md README.md to %doc - separate your changelog entries by a new line - Put the html documenation → documentation - %{_datadir}/doc/ → %{_docdir} - No: %{_libdir}/* The versioned library (.so.X.x.x) must go to the main package and the unversioned library (.so) must go to the devel package. See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages. Do not glob the major soname version of the versioned library while doing this: %files %license edl-v10 epl-v10 %{_libdir}/libpaho-mqttpp3.so.1* %files devel %{_includedir}/mqtt %{_libdir}/libpaho-mqttpp3.so - Be more specific here: %{_includedir}/mqtt - This should go to %{_libdir} too not /usr/lib: /usr/lib/cmake/PahoMqttCpp Consider sending a patch upstream to fix this. - The description is too long, it must be wrapped around at 80 characters max per line: The Paho MQTT CPP Client is a fully fledged MQTT client written in ANSI standard C++ 11. - If you use cmake3 for EPEL7 (otherwise the 3 is not needed) you should use the cmake macros with 3 too: %build %cmake3 -DPAHO_WITH_SSL=TRUE -DPAHO_BUILD_DOCUMENTATION=TRUE %cmake3_build %install %cmake3_install - The readme file mentions some tests, could you try to run them with %ctest? - There's an extra 1 at the end here and -p0 is not necessary without the patch: %autosetup -n paho.mqtt.cpp-%{version} -p0 1 - You need to BuildRequires: gcc-c++, not gcc - You need to constrain BuildRequires: paho-c-devel >= 1.3.8 for paho-cpp 1.2.0. I have taken the liberty to update it from 1.3.4 to 1.3.9 on Rawhide. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
