https://bugzilla.redhat.com/show_bug.cgi?id=1961783 Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(mhayden@xxxxxxxxx | |m) --- Comment #9 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== Issues ===== - The base package is named as an application rather than a library (rofimoji rather than python-rofimoji), which I think is correct. Since this is an application, I think you should put everything in the base package and drop the python3-rofimoji subpackage. The subpackage doesn’t offer an importable package or module called “rofimoji” as you would expect by its name, and the package that is installed (“picker”) is clearly designed as the tool implementation rather than as an API. You could move the BuildRequires and Requires from python3-rofimoji into the base rofimoji package, change %files -n python3-%{srcname} -f %{pyproject_files} to %files -f %{pyproject_files} and drop the python3-rofimoji subpackage altogether. It wouldn’t hurt to add the following to the base package, then, although I am not convinced it is required because the package is only intended to be imported by the application: %py_provides python3-picker - You can, if you like, move Version: 5.1.0 back below Name: %{srcname} and the expansion of %global tag %{version} will still work. - You have placed %generate_buildrequires %pyproject_buildrequires -r as if it were part of %prep, but %generate_buildrequires is its own section. To make it less confusing, add a blank line before %generate_buildrequires. While there is no technical requirement to put %generate_buildrequires in a particular part of the spec file, a more common placement for this would be after the base package’s %description. - This looks like it is left over from an experiment: echo "error" >&2 - The quotes here are unnecessary and unusal: %pyproject_save_files 'picker' - I tried the package in an actual Wayland session on Fedora 34. I was unable to type into the filter field, and when I double-clicked an emoji, I got “Compositor does not support the virtual keyboard protocol” in the terminal. Does it work for you? ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Expat License", "*No copyright* Expat License". 314 files have unknown license. Detailed output of licensecheck in /home/reviewer/1961783-rofimoji/re- review/1961783-rofimoji/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [!]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. Upstream provides no tests. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: python3-rofimoji-5.1.0-4.fc35.noarch.rpm rofimoji-5.1.0-4.fc35.src.rpm python3-rofimoji.noarch: W: spelling-error %description -l en_US emoji -> emotive python3-rofimoji.noarch: W: spelling-error %description -l en_US dmenu -> menu, d menu, madmen python3-rofimoji.noarch: E: non-executable-script /usr/lib/python3.9/site-packages/picker/rofimoji.py 644 /usr/bin/env python3 rofimoji.src: W: spelling-error Summary(en_US) rofi -> profit rofimoji.src: W: spelling-error %description -l en_US emoji -> emotive rofimoji.src: W: spelling-error %description -l en_US rofi -> profit rofimoji.src: W: spelling-error %description -l en_US dmenu -> menu, d menu, madmen rofimoji.src: W: spelling-error %description -l en_US wofi -> woof 2 packages and 0 specfiles checked; 1 errors, 7 warnings. Rpmlint (installed packages) ---------------------------- python3-rofimoji.noarch: W: spelling-error %description -l en_US emoji -> emotive python3-rofimoji.noarch: W: spelling-error %description -l en_US dmenu -> menu, d menu, madmen python3-rofimoji.noarch: E: non-executable-script /usr/lib/python3.9/site-packages/picker/rofimoji.py 644 /usr/bin/env python3 1 packages and 0 specfiles checked; 1 errors, 2 warnings. Source checksums ---------------- https://github.com/fdw/rofimoji/archive/5.1.0/rofimoji-5.1.0.tar.gz : CHECKSUM(SHA256) this package : fba77f79c131f9423e0e92c22cd288c903f202ee46e8512740b732cc8df03f2d CHECKSUM(SHA256) upstream package : fba77f79c131f9423e0e92c22cd288c903f202ee46e8512740b732cc8df03f2d Requires -------- python3-rofimoji (rpmlib, GLIBC filtered): (python3.9dist(configargparse) < 2 with python3.9dist(configargparse) > 0.15) /usr/bin/python3 python(abi) rofi wl-clipboard wofi wtype xclip xdotool xsel Provides -------- python3-rofimoji: python-rofimoji python3-rofimoji python3.9-rofimoji python3.9dist(rofimoji) python3dist(rofimoji) Diff spec file in url and in SRPM --------------------------------- --- /home/reviewer/1961783-rofimoji/re-review/1961783-rofimoji/srpm/rofimoji.spec 2021-05-29 08:10:49.992386971 -0400 +++ /home/reviewer/1961783-rofimoji/re-review/1961783-rofimoji/srpm-unpacked/rofimoji.spec 2021-05-27 14:37:23.000000000 -0400 @@ -45,4 +45,5 @@ %generate_buildrequires %pyproject_buildrequires -r +echo "error" >&2 %build Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1961783 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Python, Generic Disabled plugins: PHP, Ruby, Ocaml, Java, SugarActivity, C/C++, R, fonts, Perl, Haskell Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
