https://bugzilla.redhat.com/show_bug.cgi?id=1923830 Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #17 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> --- Sorry for the delay---got very busy all of a sudden. OK, that looks good! There are one or two items remaining, but you can do those before you import the package. - in the files section, you only need the one line (since it implies that it also owns all sub-directories): %{_datadir}/gnome/help/%{name} instead of %{_datadir}/gnome/help/%{name} %{_datadir}/gnome/help/%{name}/C %{_datadir}/gnome/help/%{name}/cs %{_datadir}/gnome/help/%{name}/it %{_datadir}/gnome/help/%{name}/ru - rpmlint shows that the FSF address in the license file is wrong (it uses the old address and needs to be updated) diffuse.noarch: E: incorrect-fsf-address /usr/share/licenses/diffuse/COPYING please file a ticket upstream to ask them to update this (please do not update the address yourself, since we must use the license file in the form that upstream provides it). XXX APPROVED XXX With regards to sponsorship to the packagers group, could you review one or two tickets please? Reviewing packages for colleagues is as much a duty of us package maintainers as maintaining our own packages is. So you also need to know how to do that. You can use `fedora-review` to help you. I guess you continue from this bit: https://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Add_Package_to_Source_Code_Management_.28SCM.29_system_and_Set_Owner I'll be happy to help with your reviews too, of course. Please feel free to CC me to any tickets and ask me any questions on them (or directly over e-mail at ankursinha AT fedoraproject.org) . You can find all tickets awaiting review here: https://fedoraproject.org/PackageReviewStatus/ Please note in your reviews that you are awaiting sponsorship (since you cannot approve packages until you are sponsored). Cheers, Ankur -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
