https://bugzilla.redhat.com/show_bug.cgi?id=1964787 Richard W.M. Jones <rjones@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(damien.lemoal@wdc | |.com) --- Comment #1 from Richard W.M. Jones <rjones@xxxxxxxxxx> --- We'd normally prefer you did not add a license to the spec file itself. For details see https://fedoraproject.org/wiki/Licensing:Main#License_of_Fedora_SPEC_Files You need to drop the BuildRoot line entirely. It'd be nice if the BuildRequires line at least had spaces between the names, but ideally you'd list the BuildRequires one per line, eg: BuildRequires: device-mapper-devel BuildRequires: kmod-devel etc In particular this makes it easier to comment out or conditionalize particular BRs if necessary later. > This is my first package submission to Fedora and I need a sponsor. I don't think I will be able to be a sponsor, but see also this recent discussion: https://pagure.io/packager-sponsors/issue/470 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
