[Bug 240500] Review Request: R-Biobase 1.14.0 - Functions that are needed by many other packages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: R-Biobase 1.14.0 - Functions that are needed by many other packages


https://bugzilla.redhat.com/show_bug.cgi?id=240500





------- Additional Comments From alexl@xxxxxxxxxxxxxxxxxxxxx  2007-11-18 07:21 EST -------
Full review:

       - OK: rpmlint output (can probably ignore these warnings):
R-Biobase.i386: W: one-line-command-in-%post /usr/lib/rpm/R-make-search-index.sh
R-Biobase.i386: W: one-line-command-in-%postun /usr/lib/rpm/R-make-search-index.sh
       - NEEDS-WORK: install line should be similar to
%{_bindir}/R CMD INSTALL -l $RPM_BUILD_ROOT%{_libdir}/R/library %{packname}
      - NEEDS-WORK: "Requires: R" may not be necessary because this is compiled
against libR.so and therefore gets the R dependency automatically
      - OK: License text is not in package, ask upstream to include it, if possible
      - OK: License is OK (Artistic 2.0)
      - OK: Meets Package Naming Guidelines.
      - NEEDS-WORK: Summary is vague and doesn't indicate that this is part of
Bioconductor
"Functions that are needed by many other packages" doesn't mention Bioconductor,
I would use something similar description from here
http://www.bioconductor.org/packages/2.2/bioc/html/Biobase.html "Base functions
for Bioconductor".
      - NEEDS-WORK: Description is also vague and almost identical to Summary,
this would be a good place to mention this part of the Bioconductor project etc.
 This is also true of the other dependent packages from Bioconductor that you
maintain: R-tkWidgets, the descriptions and summary should indicate that they
are part of Bioconductor
      - NEEDS-WORK Group is inappropriate  should be Applications/Engineering
rather than Applications/Productivity (this also applies to R-tkWidgets etc.)
      - OK: The spec file name
      - OK: Meets the Packaging Guidelines
      - OK: Spec file in American English
      - OK: The spec file legible
      - NEEDS-WORK: %changelog is badly formatted, there needs to be spaces
between each dated entry and spaces between "*" and "-"
      - NEEDS-WORK:  not using most recent upstream which is 1.17.5 here are the
MD5sums:
ed57a9494bd88ff6d81eb92f1363bbaa  Biobase_1.17.3.tar.gz
63d808d3ea0b662d58a339ddbf71639a  Biobase_1.17.5.tar.gz
      - OK: Builds OK on F-7 in koji
      - OK: no %find_lang, no locales as yet
      - OK: ldconfig: not required (noarch)
      - OK: not relocatable
      - OK: Own all directories that it creates
      - OK: No duplicate files
      - OK: %defattr(...):
      - OK: %clean section
      - OK: Consistently use macros
      - OK: Contains code
      - OK: No large doc
      - OK: %doc not critical for run-time
      - OK: no devel package
      - OK: no static libraries
      - OK: No pkgconfig(.pc) files
      - OK: no library files with suffix

SHOULD:
       - OK: builds in moch/koji
       - OK: module loads properly in R
       - NEEDS-WORK: query upstream to include license
       - OK: have translations of summary and description in fr

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]