https://bugzilla.redhat.com/show_bug.cgi?id=1961783 Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(mhayden@xxxxxxxxx | |m) --- Comment #2 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== Issues ===== - Rpmlint reports: python3-rofimoji.noarch: E: non-executable-script /usr/lib/python3.9/site-packages/picker/rofimoji.py 644 /usr/bin/env python3 You can remove the shebang line in %prep: # No need for this to be a script when installed in site-packages: sed -r -i 's/1{/^#!/d}/' picker/rofimoji.py The entry point via /usr/bin/rofimoji will still work, of course. - By default (installed in a clean mock chroot) the roflmoji command fails with Could not find a valid way to type characters. Please check the required dependencies. To support both Wayland and X11 sessions, it seems that rofimoji should have: # X11 Requires: rofi Requires: xsel Requires: xclip Requires: xdotool # Wayland Requires: wofi # For wl-copy Requires: wl-clipboard Requires: wtype You might argue that these should all be weak dependencies (https://docs.fedoraproject.org/en-US/packaging-guidelines/WeakDependencies/), but I think that this is not appropriate since rofimoji will not function at all without the appropriate group of dependencies for the session. - Since wtype is needed for this package to work with Wayland sessions, you should package it first. It is a very simple package, and I will be happy to review it as well, and to answer questions about packaging it. https://github.com/atx/wtype - The spec file in the SRPM is (trivially) different from the one in the spec file link. - The pattern for the man page should allow for the compression format to change. Change this: %{_mandir}/man1/%{name}.1.gz to this: %{_mandir}/man1/%{name}.1* See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Expat License", "*No copyright* Expat License". 314 files have unknown license. Detailed output of licensecheck in /home/reviewer/1961783-rofimoji/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [!]: Package functions as described. See Issues section; some dependencies are needed. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: python3-rofimoji-5.1.0-2.fc35.noarch.rpm rofimoji-5.1.0-2.fc35.src.rpm python3-rofimoji.noarch: W: spelling-error %description -l en_US emoji -> emotive python3-rofimoji.noarch: W: spelling-error %description -l en_US dmenu -> menu, d menu, madmen python3-rofimoji.noarch: W: spelling-error %description -l en_US wofi -> woof python3-rofimoji.noarch: E: non-executable-script /usr/lib/python3.9/site-packages/picker/rofimoji.py 644 /usr/bin/env python3 rofimoji.src: W: spelling-error Summary(en_US) rofi -> profit rofimoji.src: W: spelling-error %description -l en_US emoji -> emotive rofimoji.src: W: spelling-error %description -l en_US rofi -> profit rofimoji.src: W: spelling-error %description -l en_US dmenu -> menu, d menu, madmen rofimoji.src: W: spelling-error %description -l en_US wofi -> woof 2 packages and 0 specfiles checked; 1 errors, 8 warnings. Rpmlint (installed packages) ---------------------------- python3-rofimoji.noarch: W: spelling-error %description -l en_US emoji -> emotive python3-rofimoji.noarch: W: spelling-error %description -l en_US dmenu -> menu, d menu, madmen python3-rofimoji.noarch: W: spelling-error %description -l en_US wofi -> woof python3-rofimoji.noarch: E: non-executable-script /usr/lib/python3.9/site-packages/picker/rofimoji.py 644 /usr/bin/env python3 1 packages and 0 specfiles checked; 1 errors, 3 warnings. Source checksums ---------------- https://github.com/fdw/rofimoji/archive/5.1.0/rofimoji-5.1.0.tar.gz : CHECKSUM(SHA256) this package : fba77f79c131f9423e0e92c22cd288c903f202ee46e8512740b732cc8df03f2d CHECKSUM(SHA256) upstream package : fba77f79c131f9423e0e92c22cd288c903f202ee46e8512740b732cc8df03f2d Requires -------- python3-rofimoji (rpmlib, GLIBC filtered): (python3.9dist(configargparse) < 2 with python3.9dist(configargparse) > 0.15) /usr/bin/python3 python(abi) python3.9dist(setuptools) rofi Provides -------- python3-rofimoji: python-rofimoji python3-rofimoji python3.9-rofimoji python3.9dist(rofimoji) python3dist(rofimoji) Diff spec file in url and in SRPM --------------------------------- --- /home/reviewer/1961783-rofimoji/srpm/rofimoji.spec 2021-05-21 08:36:58.634283648 -0400 +++ /home/reviewer/1961783-rofimoji/srpm-unpacked/rofimoji.spec 2021-05-14 09:22:32.000000000 -0400 @@ -41,4 +41,5 @@ %py3_install +# Note that there is no %%files section for the unversioned python module %files -n python3-%{srcname} %license LICENSE @@ -54,3 +55,3 @@ * Fri May 14 2021 Major Hayden <major@xxxxxxxx> - 5.1.0-1 -- Initial build. +- Initial build. \ No newline at end of file Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1961783 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, Python Disabled plugins: Java, Haskell, R, Ocaml, fonts, SugarActivity, Ruby, PHP, C/C++, Perl Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
