https://bugzilla.redhat.com/show_bug.cgi?id=1962864 Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxx --- Comment #2 from Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> --- Small nitpick from me: > %{__ln_s} %{_datadir}/fonts/gnu-free/FreeSansBold.ttf ${FONTFILE} While I can't find any specific paragraph for this in the Packaging Guidelines, I believe it's recommended not to rely on hard-coded font paths, and instead use fontconfig to determine them. I'd look like this: > %global fontlist font(freesans) > BuildRequires: fontconfig > BuildRequires: %{fontlist} > Requires: %{fontlist} > ... > ln -s "$(fc-match -f '%%{file}' 'Free Sans:Bold')" "${FONTFILE}" For an example of this in action, you can check the opensurge package spec: https://src.fedoraproject.org/rpms/opensurge/raw/e9e580368df1227d965638ba1a5a08e49e21ac26/f/opensurge.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
