[Bug 1961479] Review Request: golang-github-deislabs-oras - OCI Registry As Storage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1961479



--- Comment #2 from Olivier Lemasle <o.lemasle@xxxxxxxxx> ---
You can fix the broken test instead of removing it.

Actually, the error in content_test.go is caused by the test directory ".test"
which is missing [1].
When running the tests with "make test", the ".test" directory is actually
created before running the tests [2]

You can then replace in your spec:

rm pkg/content/content_test.go

by:

mkdir .test/


[1]
https://github.com/deislabs/oras/blob/5bfe0ab04a0f6fcdc5de4294cc79fb5b2e23a9a5/pkg/content/content_test.go#L51
[2]
https://github.com/deislabs/oras/blob/5bfe0ab04a0f6fcdc5de4294cc79fb5b2e23a9a5/scripts/test.sh#L7


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux