https://bugzilla.redhat.com/show_bug.cgi?id=1962269 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |decathorpe@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx Doc Type|--- |If docs needed, set a value Flags| |fedora-review+ --- Comment #2 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Taking on this review request. ================================================================================ Package was generated with rust2rpm, which simplifies the review process: - package builds and installs on rawhide without errors - windows-specific dependencies are removed - test suite is run and all tests pass - latest version is packaged - license tag matches upstream specification ("MIT") and is acceptable There is one "cosmetic" issue: The value for the Summary tag is way too long. Please trim it to some sensible length, something like: Summary: Curses libary for Rust that supports both Unix and Windows Please fix this before importing the package to Fedora. Other than that, package is APPROVED. ================================================================================ Note 1: You might want to "normalize" the changelog date format to the format that is used by rpmdev-bumpspec (i.e. drop time and timezone) for better compatibility with older RPM versions. Note 2: If you're going to build this package for both rawhide and F34 (I assume you do), please also make sure to submit an update for rust-ncurses-5.101.0-2 (with the added ncurses-devel Requires) to F34. Otherwise it might not build there. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
