Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: netdump-server - netdump crash recovery capture server https://bugzilla.redhat.com/show_bug.cgi?id=378791 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: netdump- |Review Request: netdump- |server - netdump crash |server - netdump crash |recovery capture server |recovery capture server ------- Additional Comments From tibbs@xxxxxxxxxxx 2007-11-17 22:23 EST ------- Some comments: This fails to build for me due to a missing dependency on popt-devel. Adding that gets it building. Your BuildRoot: is incorrect; see http://fedoraproject.org/wiki/Packaging/Guidelines If you call useradd in %pre, you need to have Requires(pre): shadow-utils. You can't just Require: it. Probably best to follow the established guidelines for adding users/groups: http://fedoraproject.org/wiki/Packaging/UsersAndGroups License tag need to specify the version of the GPL which applies; see http://fedoraproject.org/wiki/Licensing Is there really no upstream source for this package? Let's go over the rpmlint output: netdump-server.x86_64: W: spurious-executable-perm /usr/share/doc/netdump-server-0.7.16/example_scripts/netdump-reboot netdump-server.x86_64: W: spurious-executable-perm /usr/share/doc/netdump-server-0.7.16/example_scripts/netdump-nospace netdump-server.x86_64: W: spurious-executable-perm /usr/share/doc/netdump-server-0.7.16/example_scripts/netdump-crash netdump-server.x86_64: W: spurious-executable-perm /usr/share/doc/netdump-server-0.7.16/example_scripts/netdump-start Generally documentation shouldn't be executable. netdump-server.x86_64: E: zero-length /var/crash/.ssh/authorized_keys2 Since comments are valid in that file, it might be nice to at least include one indicating what's supposed to go there. netdump-server.x86_64: E: non-readable /var/crash/.ssh/authorized_keys2 0600 This is OK; the file isn't supposed to be public. netdump-server.x86_64: W: hidden-file-or-dir /var/crash/.ssh This is OK; it's not as if you have a choice of what to name the .ssh directory. netdump-server.x86_64: W: incoherent-version-in-changelog -0.7.16-15 0.7.16-15.fc9 A space between the dash and the version should quiet this. See the Changelogs section of http://fedoraproject.org/wiki/Packaging/Guidelines netdump-server.x86_64: W: invalid-license GPL Need to specify GPL version. netdump-server.x86_64: W: no-url-tag Depends on whether there's really an upstream for this package. The rest are all non-standard-{uid,gid} complaints, which are OK in this case. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review