[Bug 1961166] Review Request: perl-Test2-Tools-Process - Unit tests for code that calls exit, exec, system or qx()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1961166

Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #1 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Test2-Tools-Process-0.05-1.fc35.noarch.rpm | sort |
uniq -c | grep -v rpmlib
      1 perl(base)
      1 perl(Capture::Tiny)
      1 perl(Carp)
      1 perl(Class::Tiny)
      1 perl(constant)
      1 perl(Exporter)
      1 perl(:MODULE_COMPAT_5.32.1)
      1 perl(Ref::Util)
      1 perl(Scope::Upper)
      1 perl(strict)
      1 perl(Test2::API) >= 1.302015
      1 perl(Test2::Compare) >= 0.000060
      1 perl(Test2::Compare::Array) >= 0.000060
      1 perl(Test2::Compare::Custom) >= 0.000060
      1 perl(Test2::Compare::Number) >= 0.000060
      1 perl(Test2::Compare::String) >= 0.000060
      1 perl(Test2::Compare::Wildcard) >= 0.000060
      1 perl(Test2::Tools::Compare) >= 0.000060
      1 perl(Test2::Tools::Process)
      1 perl(Test2::Tools::Process::ReturnMultiLevel)
      1 perl(:VERSION) >= 5.10.0
      1 perl(warnings)
Binary requires are almost Ok.
FIX: Add missing run-requires
     - perl(Config) - lib/Test2/Tools/Process.pm:202

$ rpm -qp --provides perl-Test2-Tools-Process-0.05-1.fc35.noarch.rpm | sort |
uniq -c
      1 perl(Test2::Tools::Process) = 0.05
      1 perl-Test2-Tools-Process = 0.05-1.fc35
      1 perl(Test2::Tools::Process::Event)
      1 perl(Test2::Tools::Process::Exec)
      1 perl(Test2::Tools::Process::Exit)
      1 perl(Test2::Tools::Process::Proc)
      1 perl(Test2::Tools::Process::ReturnMultiLevel)
      1 perl(Test2::Tools::Process::System)
      1 perl(Test2::Tools::Process::SystemProc)
      1 perl(Test::Exec) = 0.05
      1 perl-Test-Exec = 0.05-1.fc35
Binary provides are Ok.

Binary requires and provides for perl-Test2-Tools-Process-tests are Ok.

$ rpmlint ./perl-Test2-Tools-Process*
perl-Test2-Tools-Process.noarch: W: spelling-error Summary(en_US) qx -> q, x,
ex
perl-Test2-Tools-Process.noarch: W: spelling-error %description -l en_US
readpipe -> read pipe, read-pipe, readership
perl-Test2-Tools-Process.noarch: W: spelling-error %description -l en_US qx ->
q, x, ex
perl-Test2-Tools-Process.src: W: spelling-error Summary(en_US) qx -> q, x, ex
perl-Test2-Tools-Process.src: W: spelling-error %description -l en_US readpipe
-> read pipe, read-pipe, readership
perl-Test2-Tools-Process.src: W: spelling-error %description -l en_US qx -> q,
x, ex
perl-Test2-Tools-Process-tests.noarch: W: no-documentation
3 packages and 1 specfiles checked; 0 errors, 7 warnings.
Rpmlint is ok


The package is in line with Fedora and Perl packaging guide lines.
Please correct 'FIX' item.

Resolution:
Approved


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux