https://bugzilla.redhat.com/show_bug.cgi?id=1959987 Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(susi.lehtola@iki. | |fi) --- Comment #1 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- This a very high-quality submission. Thanks! Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ You have correctly BR’d gcc-gfortran, which implies gcc, so fedora-review may be a bit overzealous here. Still, a direct BR on plain gcc wouldn’t hurt since you do have some C sources. It’s a minor quibble at most. - From rpmlint: crest.x86_64: E: summary-too-long C Conformer-Rotamer Ensemble Sampling Tool based on the xtb Semiempirical Extended Tight-Binding Program Package Looking at the description, which suggests the above summary is out of date anyway, why not use something like this? Summary: Utility/driver program for xtb - It looks like you should have something like: # The entire source is GPLv3+ except: # # GPLv2+: # - src/symmetry_i.c # LGPLv2+: # - src/ls_rmsd.f90 # - src/spline.f90 # # Certain build-system files are LGPLv3+, but they do not contribute to the # license of the built RPMs. License: GPLv3+ and GPLv2+ and LGPLv2+ Please see https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_multiple_licensing_scenarios for the relevant guidelines. - The following file has an obsolete Free Software Foundation postal address in its license statement. Please bring this to the attention of the upstream developers so they can fix it in a future release. - src/symmetry_i.c - Please change: %define soname 6 to: %global soname 6 See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_global_preferred_over_define. ===== Notes (not Issues!) ===== - Correctly justified ExcludeArch: s390x. Please file a bugzilla blocking F-ExcludeArch-s390x after the package is imported (https://docs.fedoraproject.org/en-US/packaging-guidelines/#_architecture_build_failures), and add a link above the ExcludeArch in the spec file at that time. - My compliments on getting the flexiblas part correct, and on getting the necessary patch included upstream. ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* GNU Lesser General Public License v3.0 or later", "Unknown or generated", "GNU Lesser General Public License v3.0 or later", "GNU Lesser General Public License v2.1 or later", "*No copyright* GNU Lesser General Public License", "GNU General Public License v2.0 or later [obsolete FSF postal address (Mass Ave)]". 33 files have unknown license. Detailed output of licensecheck in /home/reviewer/1959987-crest/licensecheck.txt See the Issues section, above. [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [-]: Package is not known to require an ExcludeArch tag. Correctly justified ExcludeArch: s390x. Please file a bugzilla blocking F-ExcludeArch-s390x after the package is imported (https://docs.fedoraproject.org/en-US/packaging-guidelines/#_architecture_build_failures). [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines (except as noted) [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. (based on tests passing) [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: Package should compile and build into binary rpms on all supported architectures. Correctly justified ExcludeArch. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [!]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define soname 6 [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: crest-2.11-1.fc35.x86_64.rpm crest-debuginfo-2.11-1.fc35.x86_64.rpm crest-debugsource-2.11-1.fc35.x86_64.rpm crest-2.11-1.fc35.src.rpm crest.x86_64: E: summary-too-long C Conformer-Rotamer Ensemble Sampling Tool based on the xtb Semiempirical Extended Tight-Binding Program Package crest.x86_64: W: spelling-error %description -l en_US analysation -> transnational, sensational, nasalization crest.x86_64: W: spelling-error %description -l en_US conformational -> informational, confrontational, confirmation crest.x86_64: W: spelling-error %description -l en_US workflow -> work flow, work-flow, workforce crest.x86_64: W: spelling-error %description -l en_US iMTD -> timid crest.x86_64: W: spelling-error %description -l en_US rotamer -> roamer, tamer crest.x86_64: W: spelling-error %description -l en_US metadynamic -> meta dynamic, meta-dynamic, aerodynamic crest.x86_64: W: spelling-error %description -l en_US functionalities -> functionalists, functionality, functionalist crest.x86_64: W: spelling-error %description -l en_US protonation -> profanation, protestation, propitiation crest.x86_64: W: spelling-error %description -l en_US deprotonation -> depredation, depreciation, deprecation crest.x86_64: W: spelling-error %description -l en_US tautomerization -> cauterization, computerization, containerization crest.x86_64: W: no-manual-page-for-binary crest crest.src: W: spelling-error Summary(en_US) xtb -> TB crest.src: E: summary-too-long C Conformer-Rotamer Ensemble Sampling Tool based on the xtb Semiempirical Extended Tight-Binding Program Package crest.src: W: spelling-error %description -l en_US xtb -> TB crest.src: W: spelling-error %description -l en_US analysation -> transnational, sensational, nasalization crest.src: W: spelling-error %description -l en_US conformational -> informational, confrontational, confirmation crest.src: W: spelling-error %description -l en_US workflow -> work flow, work-flow, workforce crest.src: W: spelling-error %description -l en_US iMTD -> timid crest.src: W: spelling-error %description -l en_US rotamer -> roamer, tamer crest.src: W: spelling-error %description -l en_US metadynamic -> meta dynamic, meta-dynamic, aerodynamic crest.src: W: spelling-error %description -l en_US functionalities -> functionalists, functionality, functionalist crest.src: W: spelling-error %description -l en_US protonation -> profanation, protestation, propitiation crest.src: W: spelling-error %description -l en_US deprotonation -> depredation, depreciation, deprecation crest.src: W: spelling-error %description -l en_US tautomerization -> cauterization, computerization, containerization 4 packages and 0 specfiles checked; 2 errors, 23 warnings. Rpmlint (debuginfo) ------------------- Checking: crest-debuginfo-2.11-1.fc35.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- crest.x86_64: E: summary-too-long C Conformer-Rotamer Ensemble Sampling Tool based on the xtb Semiempirical Extended Tight-Binding Program Package crest.x86_64: W: spelling-error %description -l en_US analysation -> transnational, sensational, nasalization crest.x86_64: W: spelling-error %description -l en_US conformational -> informational, confrontational, confirmation crest.x86_64: W: spelling-error %description -l en_US workflow -> work flow, work-flow, workforce crest.x86_64: W: spelling-error %description -l en_US iMTD -> timid crest.x86_64: W: spelling-error %description -l en_US rotamer -> roamer, tamer crest.x86_64: W: spelling-error %description -l en_US metadynamic -> meta dynamic, meta-dynamic, aerodynamic crest.x86_64: W: spelling-error %description -l en_US functionalities -> functionalists, functionality, functionalist crest.x86_64: W: spelling-error %description -l en_US protonation -> profanation, protestation, propitiation crest.x86_64: W: spelling-error %description -l en_US deprotonation -> depredation, depreciation, deprecation crest.x86_64: W: spelling-error %description -l en_US tautomerization -> cauterization, computerization, containerization crest.x86_64: W: no-manual-page-for-binary crest 3 packages and 0 specfiles checked; 1 errors, 11 warnings. Source checksums ---------------- https://github.com/grimme-lab/crest/archive/v2.11/crest-2.11.tar.gz : CHECKSUM(SHA256) this package : e6d9154b6e22a88709203945fa24f1ecccb5d5a5906111c225ad5749125252f4 CHECKSUM(SHA256) upstream package : e6d9154b6e22a88709203945fa24f1ecccb5d5a5906111c225ad5749125252f4 Requires -------- crest (rpmlib, GLIBC filtered): libc.so.6()(64bit) libflexiblas.so.3()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgfortran.so.5()(64bit) libgfortran.so.5(GFORTRAN_10)(64bit) libgfortran.so.5(GFORTRAN_8)(64bit) libgomp.so.1()(64bit) libgomp.so.1(GOMP_1.0)(64bit) libgomp.so.1(GOMP_2.0)(64bit) libgomp.so.1(GOMP_4.0)(64bit) libgomp.so.1(OMP_1.0)(64bit) libm.so.6()(64bit) rtld(GNU_HASH) xtb crest-debuginfo (rpmlib, GLIBC filtered): crest-debugsource (rpmlib, GLIBC filtered): Provides -------- crest: crest crest(x86-64) crest-debuginfo: crest-debuginfo crest-debuginfo(x86-64) debuginfo(build-id) crest-debugsource: crest-debugsource crest-debugsource(x86-64) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1959987 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, C/C++, Generic Disabled plugins: Python, Java, fonts, Perl, Ocaml, Ruby, Haskell, PHP, SugarActivity, R Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
