Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: debootstrap - Bootstrap a basic Debian GNU/Linux system Alias: debootstrap-review https://bugzilla.redhat.com/show_bug.cgi?id=329291 pertusus@xxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |pertusus@xxxxxxx Status|NEW |ASSIGNED Flag| |fedora-review+ ------- Additional Comments From pertusus@xxxxxxx 2007-11-17 18:58 EST ------- * rpmlint is silent * free software, license included * follow packaging guidelines * match upstream bd446c40b90c6069178b23065d4179ca debootstrap_1.0.7.tar.gz * %files section right * works I attached a modified version of a patch to keep the timestamp of the installed scripts. This could be perfected by a touch -r debootstrap $RPM_BUILD_ROOT%{_sbindir}/debootstrap Currently the rpm macros are not used because /usr/share and /usr/sbin are hardcoded in some places. You could overcome that by - doing a sed s;/usr/share;%{_datadir}; on debootstrap - doing a sed s;/usr/sbin;%{_sbindir}; on the Makefile - passing DSDIR=$RPM_BUILD_ROOT%{_datadir}/debootstrap on the make install line I think it would be better, but I won't make that a blocker. May be done after importing. APPROVED I am willing to maintain EL-4 and EL-5 branches, if you don't want to and accept me as a comaintainer for EPEL. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review