[Bug 370751] Review Request: ggz-client-libs - Client libraries for GGZ gaming zone

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ggz-client-libs - Client libraries for GGZ gaming zone


https://bugzilla.redhat.com/show_bug.cgi?id=370751


tibbs@xxxxxxxxxxx changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From tibbs@xxxxxxxxxxx  2007-11-17 18:36 EST -------
OK, BRs are better, License: tag reflects reality and the wrapper is gone from
its odd location.

I neglected to note that %find_lang is called properly to deal with the locale
files.  I need to add that to my checklist.

At this point, I have only two comments which I don't believe are blockers:

If possible, please try to note in the spec which bits are under which license.  

The ggc-wrapper manpage is still shipped even though the executable isn't.

But these are pretty minor.  So, APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]