https://bugzilla.redhat.com/show_bug.cgi?id=1951495 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #2 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 addresses are Ok. Source0 archive (SHA-512: ff12f9265ff1dbdca5c592b6854dbad7eabf4ce9d68d054534924cc62759aff301e41b4892677b822c30735858542f76804b18ca1be62f8f8c7aaa1fc530a035) is original. Ok. Summary verified from lib/Net/NBName.pm. Ok. Description verified from lib/Net/NBName.pm. Ok. License verified from README, lib/Net/NBName.pm, lib/Net/NBName/NodeStatus.pm, lib/Net/NBName/NodeStatus/RR.pm, lib/Net/NBName/NameQuery.pm, and lib/Net/NBName/NameQuery/RR.pm. Ok. No XS code, noarch BuildArch is Ok. Net::Netmask is not used at tests. Ok. TODO: You could build-require perl-generators (it's in EPEL). TODO: You could replace a sed call with perl to drop one dependency. TODO: You could replace "find ... -exec rm -f {} ;" with "find ... -delete" All tests pass. Ok. $ rpmlint perl-Net-NBName.spec ../SRPMS/perl-Net-NBName-0.26-41.fc35.src.rpm ../RPMS/noarch/perl-Net-NBName-0.26-41.fc35.noarch.rpm perl-Net-NBName.noarch: W: no-manual-page-for-binary namequery.pl perl-Net-NBName.noarch: W: no-manual-page-for-binary nodescan.pl perl-Net-NBName.noarch: W: no-manual-page-for-binary nodestat.pl 2 packages and 1 specfiles checked; 0 errors, 3 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Net-NBName-0.26-41.fc35.noarch.rpm -rwxr-xr-x 1 root root 641 May 14 13:37 /usr/bin/namequery.pl -rwxr-xr-x 1 root root 772 May 14 13:37 /usr/bin/nodescan.pl -rwxr-xr-x 1 root root 309 May 14 13:37 /usr/bin/nodestat.pl drwxr-xr-x 2 root root 0 May 14 13:37 /usr/share/doc/perl-Net-NBName -rw-r--r-- 1 root root 1836 May 14 13:37 /usr/share/doc/perl-Net-NBName/Changes -rw-r--r-- 1 root root 878 May 14 13:37 /usr/share/doc/perl-Net-NBName/README -rw-r--r-- 1 root root 4130 May 14 13:37 /usr/share/man/man3/Net::NBName.3pm.gz -rw-r--r-- 1 root root 1664 May 14 13:37 /usr/share/man/man3/Net::NBName::NameQuery.3pm.gz -rw-r--r-- 1 root root 1602 May 14 13:37 /usr/share/man/man3/Net::NBName::NameQuery::RR.3pm.gz -rw-r--r-- 1 root root 1544 May 14 13:37 /usr/share/man/man3/Net::NBName::NodeStatus.3pm.gz -rw-r--r-- 1 root root 1955 May 14 13:37 /usr/share/man/man3/Net::NBName::NodeStatus::RR.3pm.gz drwxr-xr-x 2 root root 0 May 14 13:37 /usr/share/perl5/vendor_perl/Net drwxr-xr-x 2 root root 0 May 14 13:37 /usr/share/perl5/vendor_perl/Net/NBName -rw-r--r-- 1 root root 13311 Jun 27 2006 /usr/share/perl5/vendor_perl/Net/NBName.pm drwxr-xr-x 2 root root 0 May 14 13:37 /usr/share/perl5/vendor_perl/Net/NBName/NameQuery -rw-r--r-- 1 root root 2788 Jun 25 2006 /usr/share/perl5/vendor_perl/Net/NBName/NameQuery.pm -rw-r--r-- 1 root root 1851 Jun 25 2006 /usr/share/perl5/vendor_perl/Net/NBName/NameQuery/RR.pm drwxr-xr-x 2 root root 0 May 14 13:37 /usr/share/perl5/vendor_perl/Net/NBName/NodeStatus -rw-r--r-- 1 root root 2163 Jun 25 2006 /usr/share/perl5/vendor_perl/Net/NBName/NodeStatus.pm -rw-r--r-- 1 root root 3418 Jun 25 2006 /usr/share/perl5/vendor_perl/Net/NBName/NodeStatus/RR.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Net-NBName-0.26-41.fc35.noarch.rpm | sort -f | uniq -c 1 /usr/bin/perl 1 perl(:MODULE_COMPAT_5.32.1) 1 perl(Net::NBName) 1 perl(Net::NBName::NameQuery) 1 perl(Net::NBName::NameQuery::RR) 1 perl(Net::NBName::NodeStatus) 1 perl(Net::NBName::NodeStatus::RR) 1 perl(Net::Netmask) 1 perl(Socket) 1 perl(strict) 1 perl(vars) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Net-NBName-0.26-41.fc35.noarch.rpm | sort -f | uniq -c 1 perl(Net::NBName) = 0.26 1 perl(Net::NBName::NameQuery) = 0.26 1 perl(Net::NBName::NameQuery::RR) = 0.26 1 perl(Net::NBName::NodeStatus) = 0.26 1 perl(Net::NBName::NodeStatus::RR) = 0.26 1 perl(Net::NBName::Request) 1 perl-Net-NBName = 0.26-41.fc35 Binary requires are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Net-NBName-0.26-41.fc35.noarch.rpm Binary dependencies are resolvable. Ok. TODO: The package build fails to build in F35 (https://koji.fedoraproject.org/koji/taskinfo?taskID=67894236): Processing files: perl-Net-NBName-0.26-41.fc35.noarch error: File must begin with "/": %{perl_vendorlib}/Net The package build in EPEL7 (https://koji.fedoraproject.org/koji/taskinfo?taskID=67894271) Ok. The EPEL7 build is installable with EPEL7 repository. Ok. The package is in line with EPEL7 packaging guidelines. Please consider fixing the TODO items before building this package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
