Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Harmony - Software to program the Logitech Harmony remote control https://bugzilla.redhat.com/show_bug.cgi?id=328161 ------- Additional Comments From s-t-rhbugzilla@xxxxxxxxxxxxx 2007-11-17 18:08 EST ------- Before being pointed at this package review request, I also attempted to package this utility, in bug 388931. It looks like this package is far ahead of mine in features. However, I do have a couple of comments: 1) Do you need "Requires: libusb", or does the BuildRequires do this automatically? 2) There's a header file with Microsoft copyright in win/setupapi.h. This doesn't get into the file .rpm file, but is shipped in the .srpm file. According to another review request I submitted, shipping "bad" stuff even in just the .srpm is bad. As such, I made my package use a modified source .tar.bz2 with this file removed - see harmony-generate-tarball.sh in my .srpm. Does this technique need to be integrated into this .srpm? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review