https://bugzilla.redhat.com/show_bug.cgi?id=1895567 Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #26 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- Package approved. Thanks for all your hard work on this difficult package. Please see my remaining notes below. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Mixed tabs and spaces in spec file (line 174 contains a tab); please fix this when importing. - The currently-disabled -docs subpackage has some issues: - Description has typo “Documenation” - Should really conditionalize the whole %package docs and not just %files docs - The -docs subpackage should be BuildArch: noarch - The suffix -doc, rather than -docs, would be more conventional for this subpackage. - If you set “%global __cmake_in_source_build” in the spec file, then enabling the documentation seems to work. I didn’t take time to verify that Doxygen actually found all the things it should be documenting, and by default the documentation is installed in the wrong path (/usr/docs/doxy_{html,xml} instead of %{_pkgdocdir}). I think getting the documentation building and installing properly would be great, but it doesn‘t have to block approval. Non-Issues from fedora-review: ============================== - Header files in -devel subpackage, if present. Note: usd : /usr/share/usd/examples/include/pxr/imaging/hdTiny/mesh.h usd : /usr/share/usd/examples/include/pxr/imaging/hdTiny/renderDelegate.h usd : /usr/share/usd/examples/include/pxr/imaging/hdTiny/renderPass.h usd : /usr/share/usd/examples/include/pxr/imaging/hdTiny/rendererPlugin.h See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_devel_packages This is spurious feedback from fedora-review; these are documentation. If you ever manage to build the documentation, you will need a -doc subpackage, and they should go in that. For now, they are fine where they are. - Package contains BR: python2-devel or python3-devel This is from fedora-review; it does not like pkgconfig(python3), but that is acceptable. ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Khronos License Expat License Apache License 2.0", "Apache License 2.0", "Expat License", "BSD 3-clause "New" or "Revised" License", "Apache License 2.0 [generated file]", "Khronos License", "Apache License 2.0 GNU General Public License v3.0 or later", "BSD 2-clause "Simplified" License", "the Unlicense Expat License", "*No copyright* Apache License 2.0". 2567 files have unknown license. Detailed output of licensecheck in /home/reviewer/1895567-usd/20210511/1895567-usd/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [-]: Package is not known to require an ExcludeArch tag. Package is correctly ExclusiveArch. Must file Bugzilla tickets after the package is imported to dist-git, as required by https://docs.fedoraproject.org/en-US/packaging-guidelines/#_architecture_build_failures. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 276480 bytes in 7 files. A -doc subpackage will be required if you manage to build the documentation. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in usd-libs , usd-devel , python3-usd [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: %check is present and all tests pass. Tests are disabled; this review has established the reasons why it is not practical to enable them. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: usd-21.05-2.fc35.x86_64.rpm usd-libs-21.05-2.fc35.x86_64.rpm usd-devel-21.05-2.fc35.x86_64.rpm python3-usd-21.05-2.fc35.x86_64.rpm usd-debuginfo-21.05-2.fc35.x86_64.rpm usd-debugsource-21.05-2.fc35.x86_64.rpm usd-21.05-2.fc35.src.rpm usd.x86_64: W: devel-file-in-non-devel-package /usr/share/usd/examples/include/pxr/imaging/hdTiny/mesh.h usd.x86_64: W: devel-file-in-non-devel-package /usr/share/usd/examples/include/pxr/imaging/hdTiny/renderDelegate.h usd.x86_64: W: devel-file-in-non-devel-package /usr/share/usd/examples/include/pxr/imaging/hdTiny/renderPass.h usd.x86_64: W: devel-file-in-non-devel-package /usr/share/usd/examples/include/pxr/imaging/hdTiny/rendererPlugin.h usd.x86_64: W: no-manual-page-for-binary sdfdump usd.x86_64: W: no-manual-page-for-binary sdffilter usd.x86_64: W: no-manual-page-for-binary testusdview usd.x86_64: W: no-manual-page-for-binary usdGenSchema usd.x86_64: W: no-manual-page-for-binary usdcat usd.x86_64: W: no-manual-page-for-binary usdchecker usd.x86_64: W: no-manual-page-for-binary usddiff usd.x86_64: W: no-manual-page-for-binary usddumpcrate usd.x86_64: W: no-manual-page-for-binary usdedit usd.x86_64: W: no-manual-page-for-binary usdrecord usd.x86_64: W: no-manual-page-for-binary usdresolve usd.x86_64: W: no-manual-page-for-binary usdstitch usd.x86_64: W: no-manual-page-for-binary usdstitchclips usd.x86_64: W: no-manual-page-for-binary usdtree usd.x86_64: W: no-manual-page-for-binary usdview usd.x86_64: W: no-manual-page-for-binary usdzip python3-usd.x86_64: W: no-documentation python3-usd.x86_64: W: dangling-symlink /usr/lib64/python3.9/site-packages/pxr/Usdviewq/fonts/Roboto /usr/share/fonts/google-roboto python3-usd.x86_64: W: dangling-symlink /usr/lib64/python3.9/site-packages/pxr/Usdviewq/fonts/Roboto_Mono /usr/share/fonts/google-roboto-mono python3-usd.x86_64: W: desktopfile-without-binary /usr/share/applications/org.openusd.usdview.desktop usdview usd.src:275: E: hardcoded-library-path in %{_prefix}/lib/python/pxr/*.* usd.src:277: E: hardcoded-library-path in %{_prefix}/lib/python/pxr/Usdviewq/* usd.src:174: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 174) 7 packages and 0 specfiles checked; 2 errors, 25 warnings. Rpmlint (debuginfo) ------------------- Checking: usd-libs-debuginfo-21.05-2.fc35.x86_64.rpm usd-debuginfo-21.05-2.fc35.x86_64.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- usd.x86_64: W: devel-file-in-non-devel-package /usr/share/usd/examples/include/pxr/imaging/hdTiny/mesh.h usd.x86_64: W: devel-file-in-non-devel-package /usr/share/usd/examples/include/pxr/imaging/hdTiny/renderDelegate.h usd.x86_64: W: devel-file-in-non-devel-package /usr/share/usd/examples/include/pxr/imaging/hdTiny/renderPass.h usd.x86_64: W: devel-file-in-non-devel-package /usr/share/usd/examples/include/pxr/imaging/hdTiny/rendererPlugin.h usd.x86_64: W: no-manual-page-for-binary sdfdump usd.x86_64: W: no-manual-page-for-binary sdffilter usd.x86_64: W: no-manual-page-for-binary testusdview usd.x86_64: W: no-manual-page-for-binary usdGenSchema usd.x86_64: W: no-manual-page-for-binary usdcat usd.x86_64: W: no-manual-page-for-binary usdchecker usd.x86_64: W: no-manual-page-for-binary usddiff usd.x86_64: W: no-manual-page-for-binary usddumpcrate usd.x86_64: W: no-manual-page-for-binary usdedit usd.x86_64: W: no-manual-page-for-binary usdrecord usd.x86_64: W: no-manual-page-for-binary usdresolve usd.x86_64: W: no-manual-page-for-binary usdstitch usd.x86_64: W: no-manual-page-for-binary usdstitchclips usd.x86_64: W: no-manual-page-for-binary usdtree usd.x86_64: W: no-manual-page-for-binary usdview usd.x86_64: W: no-manual-page-for-binary usdzip python3-usd.x86_64: W: no-documentation python3-usd.x86_64: W: dangling-symlink /usr/lib64/python3.9/site-packages/pxr/Usdviewq/fonts/Roboto /usr/share/fonts/google-roboto python3-usd.x86_64: W: dangling-symlink /usr/lib64/python3.9/site-packages/pxr/Usdviewq/fonts/Roboto_Mono /usr/share/fonts/google-roboto-mono 7 packages and 0 specfiles checked; 0 errors, 23 warnings. Unversioned so-files -------------------- python3-usd: /usr/lib64/python3.9/site-packages/pxr/Ar/_ar.so python3-usd: /usr/lib64/python3.9/site-packages/pxr/CameraUtil/_cameraUtil.so python3-usd: /usr/lib64/python3.9/site-packages/pxr/Garch/_garch.so python3-usd: /usr/lib64/python3.9/site-packages/pxr/Gf/_gf.so python3-usd: /usr/lib64/python3.9/site-packages/pxr/Glf/_glf.so python3-usd: /usr/lib64/python3.9/site-packages/pxr/Kind/_kind.so python3-usd: /usr/lib64/python3.9/site-packages/pxr/Ndr/_ndr.so python3-usd: /usr/lib64/python3.9/site-packages/pxr/Pcp/_pcp.so python3-usd: /usr/lib64/python3.9/site-packages/pxr/Plug/_plug.so python3-usd: /usr/lib64/python3.9/site-packages/pxr/PxOsd/_pxOsd.so python3-usd: /usr/lib64/python3.9/site-packages/pxr/Sdf/_sdf.so python3-usd: /usr/lib64/python3.9/site-packages/pxr/Sdr/_sdr.so python3-usd: /usr/lib64/python3.9/site-packages/pxr/SdrOsl/_sdrOsl.so python3-usd: /usr/lib64/python3.9/site-packages/pxr/Tf/_tf.so python3-usd: /usr/lib64/python3.9/site-packages/pxr/Trace/_trace.so python3-usd: /usr/lib64/python3.9/site-packages/pxr/Usd/_usd.so python3-usd: /usr/lib64/python3.9/site-packages/pxr/UsdAbc/_usdAbc.so python3-usd: /usr/lib64/python3.9/site-packages/pxr/UsdAppUtils/_usdAppUtils.so python3-usd: /usr/lib64/python3.9/site-packages/pxr/UsdGeom/_usdGeom.so python3-usd: /usr/lib64/python3.9/site-packages/pxr/UsdHydra/_usdHydra.so python3-usd: /usr/lib64/python3.9/site-packages/pxr/UsdImagingGL/_usdImagingGL.so python3-usd: /usr/lib64/python3.9/site-packages/pxr/UsdLux/_usdLux.so python3-usd: /usr/lib64/python3.9/site-packages/pxr/UsdMedia/_usdMedia.so python3-usd: /usr/lib64/python3.9/site-packages/pxr/UsdRender/_usdRender.so python3-usd: /usr/lib64/python3.9/site-packages/pxr/UsdRi/_usdRi.so python3-usd: /usr/lib64/python3.9/site-packages/pxr/UsdShade/_usdShade.so python3-usd: /usr/lib64/python3.9/site-packages/pxr/UsdSkel/_usdSkel.so python3-usd: /usr/lib64/python3.9/site-packages/pxr/UsdUI/_usdUI.so python3-usd: /usr/lib64/python3.9/site-packages/pxr/UsdUtils/_usdUtils.so python3-usd: /usr/lib64/python3.9/site-packages/pxr/UsdVol/_usdVol.so python3-usd: /usr/lib64/python3.9/site-packages/pxr/Usdviewq/_usdviewq.so python3-usd: /usr/lib64/python3.9/site-packages/pxr/Vt/_vt.so python3-usd: /usr/lib64/python3.9/site-packages/pxr/Work/_work.so Source checksums ---------------- https://github.com/PixarAnimationStudios/usd/archive/v21.05/usd-21.05.tar.gz : CHECKSUM(SHA256) this package : 165d0e1e45385076121268eba0da2a0ba4a7e5c2b8eab9ab26fb2fcd81a1a478 CHECKSUM(SHA256) upstream package : 165d0e1e45385076121268eba0da2a0ba4a7e5c2b8eab9ab26fb2fcd81a1a478 Requires -------- usd (rpmlib, GLIBC filtered): /usr/bin/python3 libOpenImageIO_Util.so.2.2()(64bit) libboost_program_options.so.1.75.0()(64bit) libboost_python39.so.1.75.0()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libpython3.9.so.1.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libusd_ms.so.0()(64bit) python3-usd(x86-64) rtld(GNU_HASH) usd-libs(x86-64) usd-libs (rpmlib, GLIBC filtered): ld-linux-x86-64.so.2()(64bit) libAlembic.so.1.8()(64bit) libGL.so.1()(64bit) libHalf-2_5.so.25()(64bit) libOpenColorIO.so.1()(64bit) libOpenImageIO.so.2.2()(64bit) libPtex.so.2.3()(64bit) libX11.so.6()(64bit) libboost_python39.so.1.75.0()(64bit) libc.so.6()(64bit) libdl.so.2()(64bit) libembree3.so.3()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libm.so.6()(64bit) libopenvdb.so.8.0()(64bit) libosdCPU.so.3.4.4()(64bit) libosdGPU.so.3.4.4()(64bit) liboslquery.so.1.11()(64bit) libpthread.so.0()(64bit) libpython3.9.so.1.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.1)(64bit) libstdc++.so.6(CXXABI_1.3.11)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.7)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libtbb.so.2()(64bit) rtld(GNU_HASH) usd-devel (rpmlib, GLIBC filtered): cmake-filesystem cmake-filesystem(x86-64) libusd_ms.so.0()(64bit) usd-libs(x86-64) python3-usd (rpmlib, GLIBC filtered): font(roboto) font(robotoblack) font(robotolight) font(robotomono) ld-linux-x86-64.so.2()(64bit) libOpenImageIO_Util.so.2.2()(64bit) libboost_python39.so.1.75.0()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libpython3.9.so.1.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.1)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libtbb.so.2()(64bit) libusd_ms.so.0()(64bit) python(abi) python3dist(jinja2) python3dist(pyopengl) python3dist(pyside2) rtld(GNU_HASH) usd-debuginfo (rpmlib, GLIBC filtered): usd-debugsource (rpmlib, GLIBC filtered): Provides -------- usd: bundled(SPIRV-Reflect) bundled(VulkanMemoryAllocator) bundled(double-conversion) bundled(ilmbase) bundled(lz4) bundled(pugixml) bundled(rapidjson) bundled(stb_image) bundled(stb_image_resize) bundled(stb_image_write) usd usd(x86-64) usd-libs: libusd_ms.so.0()(64bit) usd-libs usd-libs(x86-64) usd-devel: cmake(pxr) usd-devel usd-devel(x86-64) python3-usd: application() application(org.openusd.usdview.desktop) python-pxr python-usd python3-pxr python3-usd python3-usd(x86-64) python3.9-pxr python3.9-usd usd-debuginfo: debuginfo(build-id) usd-debuginfo usd-debuginfo(x86-64) usd-debugsource: usd-debugsource usd-debugsource(x86-64) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1895567 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Generic, Shell-api, Python Disabled plugins: Java, Perl, SugarActivity, Ruby, R, PHP, Haskell, fonts, Ocaml Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
