https://bugzilla.redhat.com/show_bug.cgi?id=1913870 Otto Urpelainen <oturpe@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(ti.eugene@gmail.c | |om) --- Comment #18 from Otto Urpelainen <oturpe@xxxxxx> --- Nice, thank you! Still come comments: 1. Something about the licenses is still bothering me. I'll get back when I have a bit more time to write a full response about it. 2. For AppStream, there should be maximum 1 project_license and multiple licenses encoded using AND notation there. See spec: https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-project_license Strangely, appstream-util validation did not complain, so filed an issue about that: https://github.com/hughsie/appstream-glib/issues/401 3. For man page and help, they would be useful to explain the difference between running 'qvge' and 'qvge FILENAME'. But that is a minor thing and adding missing man page is a SHOULD item, so I am completely fine with not having a man page in this case. 4. One point that I only noticed now: appdata.xml should be installed to directory given by macro %{_metainfodir}. Reference: https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/, https://docs.fedoraproject.org/en-US/packaging-guidelines/#_macros -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
