https://bugzilla.redhat.com/show_bug.cgi?id=1957928 --- Comment #9 from Neal Gompa <ngompa13@xxxxxxxxx> --- (In reply to David Cantrell from comment #8) > (In reply to Neal Gompa from comment #5) > > It was already asked before and rejected: > > https://pagure.io/packaging-committee/pull-request/942 > > Yeah, I've read that. But there's still nothing in the packaging guidelines > for Fedora that explicitly say "don't do this." > > I think you should understand the workflow that I'm using. I fail to see > how %include is a problem here because the SRPM is built from the dist-git > branch now and the spec file is processed accordingly. The resulting RPMs > contain the changelog entries in the RPM headers, so all of the data is > there. The resulting SRPM also includes the 'changelog' file which gets > installed if you ever install the source RPM locally and rebuild the > package. I see all of the comments in the PR you linked, but I have yet to > see any actual problem from the workflow I have. Maybe I'm missing > something. > This really sounds like you should just have an upstream changelog file that gets pulled in as a doc. The point of the %changelog in the package is to detail the packaging changes. I know people do mix the two, but the fundamental assumption for RPM changelogs that most people have is that they detail the changes done to the package, and the changes to the software is inside the package as a file. The problem I generally have with your method of changelogs is the usage of %include, which just makes it messy, but it's included as a source, so... *sigh* -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
