https://bugzilla.redhat.com/show_bug.cgi?id=1928586 Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |zebob.m@xxxxxxxxx Flags| |fedora-review? --- Comment #5 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> --- What about the patches? - Patch the m4 file to remove the obsolete macros, and send the patch upstream: [!]: Package should not use obsolete m4 macros Note: Some obsoleted macros found, see the attachment. See: https://fedorahosted.org/FedoraReview/wiki/AutoTools AutoTools: Obsoleted m4s found ------------------------------ AC_PROG_LIBTOOL found in: snoopy-2.4.12/configure.ac:73 See https://www.gnu.org/software/libtool/manual/html_node/LT_005fINIT.html , AC_PROG_LIBTOOL must be replaced with LT_INIT - Patch these files to use the new FSF address instead of the obsolete one, and send the patch upstream: snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/configfile.h snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/configuration.h snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/datasourceregistry.h snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/error.h snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/filtering.h snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/filterregistry.h snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/genericregistry.h snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/inputdatastorage.h snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/libsnoopy-debug-addons.h snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/log.h snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/message.h snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/misc.h snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/outputregistry.h snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/parser.h snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/snoopy.h snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/tsrm.h -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure