https://bugzilla.redhat.com/show_bug.cgi?id=1957816 Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |code@xxxxxxxxxxxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #1 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- I unfortunately don’t have time to review this right now, but at least the following from your fedora-review output above will have to be fixed: ----- > kweather.x86_64: W: incoherent-version-in-changelog 0.1.1-1 ['0.4-1.fc35', '0.4-1'] https://docs.fedoraproject.org/en-US/packaging-guidelines/#changelogs ----- > kweather.x86_64: W: invalid-license GPL-2.0+ https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/ Valid short names are listed here: https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses ----- > kweather.x86_64: E: invalid-desktopfile /usr/share/applications/org.kde.kweather.desktop value "0.3" for key "Version" in group "Desktop Entry" is not a known version https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_file_install_usage https://specifications.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html (Maybe the upstream author thinks the Version field is for the application version, rather than for the Desktop Entry Specification version to which the .desktop file conforms?) ----- You also “MUST” validate the desktop file (https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_file_install_usage) and AppData XML (https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/); maybe instead of commenting out these checks, you could patch these files as needed to pass validation until the corresponding upstream issues are fixed? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
