https://bugzilla.redhat.com/show_bug.cgi?id=1956365 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx Flags| |fedora-review+ --- Comment #1 from Fabio Valentini <decathorpe@xxxxxxxxx> --- I'll take on this review. Package was generated with rust2rpm, so the review is straightforward: - latest version is packaged - builds and installs on rawhide without errors - license matches upstream specification One issue: The crate does not ship a LICENSE file in the asn1_derive crate. Please report this upstream: https://github.com/alex/rust-asn1 There's already a LICENSE file in the git repo, which is shipped with the "main" crate. Shipping it with the asn1_derive "sub-crate" as well should be as simple as creating a symlink from "asn1_derive/LICENSE" pointing at "../LICENSE". -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
