https://bugzilla.redhat.com/show_bug.cgi?id=1955394 zm627 <zheng.ma@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(zheng.ma@xxxxxxxx | |m) | --- Comment #6 from zm627 <zheng.ma@xxxxxxxxx> --- Thanks for your quick reply, Ben! We'll revise the spec according to your comments. Here's my reply inline with your comments. > Fedora build flags are not honored. For an autotools configure script, the > best choice would be to replace........ We'll try to revise the configuration script to take environment variables. > You should provide all of the installation directories explicitly even though > the defaults seem to be OK on x86_64. Will fix in next version of spec. > There are upstream tests, but no %check section. If there are any that can be > run as an unprivileged user without special hardware, please add a %check > section and run them. Otherwise, please add a brief comment explaining why > this is not possible. We'll look into this issue and see if this section is needed, though currently we have a software fallback for no hardware issue. Thank you for your example of this section! > Did you want to install the contents of the config_file/ directory? > You could do something like this if you did. We don't have the plan to include the contents in the config_file as I know. Since the package works with the intel-qatlib package, all the configuration is set by that package for the upstream version. Thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
