https://bugzilla.redhat.com/show_bug.cgi?id=1951479 Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #3 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed BuildRequires FIX: Please add build-require perl(lib) - t/load-on-use.t:5 TODO: Add version constrain to 'perl(Module::Build::Tiny) >= 0.034' $ rpm -qp --requires perl-CLI-Osprey-0.08-1.fc35.noarch.rpm | sort | uniq -c | grep -v rpmlib 1 perl(Carp) 1 perl(CLI::Osprey::Descriptive) 1 perl(CLI::Osprey::Descriptive::Usage) 1 perl(CLI::Osprey::InlineSubcommand) 1 perl(Getopt::Long::Descriptive) >= 0.100 1 perl(Getopt::Long::Descriptive::Usage) 1 perl(:MODULE_COMPAT_5.32.1) 1 perl(Module::Runtime) 1 perl(Moo) 1 perl(Moo::Role) 1 perl(overload) 1 perl(Path::Tiny) 1 perl(Scalar::Util) 1 perl(strict) 1 perl(warnings) Binary requires are almost Ok. FIX: Please add run-require perl(Pod::Usage) - lib/CLI/Osprey/Role.pm:321 $ rpm -qp --provides perl-CLI-Osprey-0.08-1.fc35.noarch.rpm | sort | uniq -c 1 perl(CLI::Osprey) = 0.08 1 perl-CLI-Osprey = 0.08-1.fc35 1 perl(CLI::Osprey::Descriptive) = 0.08 1 perl(CLI::Osprey::Descriptive::Usage) = 0.08 1 perl(CLI::Osprey::InlineSubcommand) = 0.08 1 perl(CLI::Osprey::Role) = 0.08 Binary provides are Ok. $ rpmlint ./perl-CLI-Osprey* perl-CLI-Osprey.noarch: W: spelling-error Summary(en_US) MooX -> Mo Ox, Moo X, Moon perl-CLI-Osprey.noarch: W: spelling-error Summary(en_US) Cmd -> Cm, Cd, Cmdr perl-CLI-Osprey.src: W: spelling-error Summary(en_US) MooX -> Mo Ox, Moo X, Moon perl-CLI-Osprey.src: W: spelling-error Summary(en_US) Cmd -> Cm, Cd, Cmdr 2 packages and 1 specfiles checked; 0 errors, 4 warnings. Rpmlint is ok Otherwise the package is in line with Fedora and Perl packaging guide lines. Please correct all 'FIX' items and consider fixing 'TODO' item. Resolution: Approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
