https://bugzilla.redhat.com/show_bug.cgi?id=1956580 Xavier Bachelot <xavier@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |xavier@xxxxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |xavier@xxxxxxxxxxxx --- Comment #2 from Xavier Bachelot <xavier@xxxxxxxxxxxx> --- Hi Dennis, Quick review, based in part on what I've seen when trying to adapt the openalchemist spec, like you did. Excuse the rough list below, rather short on time to make it into a nicer shape now. Issues: - File conflicts with openalchemist, it would be cleaner to use %{datadir}/alchemyquest rather than %{datadir/openalchemist}, which needs to be changed upstream. - A lot of s/openalchemist/alchemyquest/ needs to be done in the spec. - I think providing 2 .desktop files, icons, etc.., one for alchemyquest and one for openalchemist, would help transitioning from openalchemist to alchemyquest. - If you add the /usr/bin/openalchemist symlink, missing Obsoletes/Provides for openalchemist. Minor nits: - Indent on the BR: make (which comes from the openalchemist spec, I know ;-)) - Spurious wildcard in %files for appdata and desktop file (from openalchemist too) - Sort BR: Regards, Xavier -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
