[Bug 1956643] Review Request: python-matplotlib-inline - Inline Matplotlib backend for Jupyter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1956643

Miro Hrončok <mhroncok@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mhroncok@xxxxxxxxxx



--- Comment #1 from Miro Hrončok <mhroncok@xxxxxxxxxx> ---
Spec sanity:

> URL:            https://github.com/martinRenou/matplotlib-inline

Consider using https://github.com/ipython/matplotlib-inline already:

https://github.com/ipython/matplotlib-inline/commit/bd8dc4eeb1d705c340fbf16d0f7d995538a70b32


> %generate_buildrequires
> %pyproject_buildrequires

This happens after %prep, please move it there so the spec order == execution
order.


> %description
> Inline Matplotlib backend for Jupyter

Descriptions should be sentences and end with .
I realize upstream does not give much info here :/


> # Remove bundled egg-info
> rm -rf matplotlib-inline.egg-info

This should be never needed with pyproject macros. (It is also rarely needed
with the traditional macros.)


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux