https://bugzilla.redhat.com/show_bug.cgi?id=1954478 Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |code@xxxxxxxxxxxxxxxxxx --- Comment #1 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- This is not a review, but just some preliminary notes. ----- Please read https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ to understand Python packaging practices in Fedora. It looks like you may not have done so. Please also see https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections. You can use the fedora-review command-line tool and consult https://docs.fedoraproject.org/en-US/packaging-guidelines/ReviewGuidelines/ to see some of the things people will be checking for when reviewing your package. ----- > %define version 0.4.1 > %define release 1 > Version: %{version} > Release: %{release} Do not do this. Do: > Version: 0.4.1 > Release: 1%{?dist} Note that the version and release macros are defined for you this way. See https://docs.fedoraproject.org/en-US/packaging-guidelines/DistTag/. ----- > Prefix: %{_prefix} Remove this. See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_relocatable_packages. ----- > Name: python3-proton-client This violates https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_naming. The base package should be python-%{unmangled_name}, and you should have > %package -n python3-%{unmangled_name} > %files -n python3-%{unmangled_name} as the built package. Note that this means you will have to submit a new review ticket with the correct name. ----- > Requires: python3-requests > Requires: python3-pyOpenSSL > Requires: python3-bcrypt > Requires: python3-gnupg > %{?python_disable_dependency_generator} You are *allowed* to opt out of automatic dependency generation (https://github.com/ProtonMail/proton-python-client). But since the upstream setup.py provides the necessary metadata, why would you want to? ----- > Group: ProtonVPN > Vendor: Proton Technologies AG <contact@xxxxxxxxxxxxxx> > BuildRoot: %{_tmppath}/%{unmangled_name}-%{version}-%{release}-buildroot > %clean > rm -rf $RPM_BUILD_ROOT > %defattr(-,root,root) All of these either MUST NOT or SHOULD NOT be present (https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections, https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_permissions). ----- > %setup -q -n %{unmangled_name}-%{version} -n %{unmangled_name}-%{version} should be > %setup -q -n %{unmangled_name}-%{version} ----- > %build > %{python3} setup.py build > %install > %{python3} setup.py install --single-version-externally-managed -O1 --root=$RPM_BUILD_ROOT --record=INSTALLED_FILES Why not just this? When you don’t use the standard macros, it’s hard to tell at a glance whether you’re trying to do something unusual. > %build > %py3_build > %install > %py3_install ----- The upstream repository has tests, so you should run them (at least, any tests that do not require network access). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
