Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: lsvpd - A utility to list device Vital Product Data (VPD) information. https://bugzilla.redhat.com/show_bug.cgi?id=307901 ------- Additional Comments From rc040203@xxxxxxxxxx 2007-11-17 08:37 EST ------- MUSTFIX: * You must not touch the running system when building a package, like you do here: %install %{__rm} -rf $RPM_BUILD_ROOT %{__make} install DESTDIR=$RPM_BUILD_ROOT if [ -e /etc/udev/rules.d/99-lsvpd.rules ] ; then %{__rm} /etc/udev/rules.d/99-lsvpd.rules fi if [ -e /etc/udev/rules.d/99-lsvpd.disabled ] ; then %{__rm} /etc/udev/rules.d/99-lsvpd.disabled fi * Missing: Requires(post): /usr/sbin/vpdupdate * Replace all /etc/lsvpd with %{_sysconfdir}/lsvpd It this package which installs it there through %configure * Requires: /sbin/chkconfig is wrong You want Requires(post) and Requires(preun). * Remove stray/unused %postun CONSIDER: * Consider to remove inserv etc. I an not sure if we want Fedora's rpms' scriptlets to be cluttered with insserv. * Would you please explain: Requires: libvpd_cxx AFAIS, this is superflous and should be removed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review