https://bugzilla.redhat.com/show_bug.cgi?id=1955107 Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxx --- Comment #1 from Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> --- > Source0: http://downloads.sf.net/fillets/fillets-ng-%{version}.tar.gz This can be switched to https. > %build > %configure --datadir=%{_datadir}/fillets-ng > %{__make} %{?_smp_mflags} 1. Macro forms of system executables are discouraged. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_macros 2. make was removed from the buildroot, starting in F34. You'll need to a add a BuildRequires: for it. https://fedoraproject.org/wiki/Changes/Remove_make_from_BuildRoot > BuildRequires: /usr/bin/appstream-util Prefer %{_bindir} instead of /usr/bin here, or just change this to "BuildRequires: libappstream-glib". > %{__mkdir_p} %{buildroot}%{_datadir}/applications > ... > mkdir -p $RPM_BUILD_ROOT%{_datadir}/appdata Please choose either %{buildroot} or ${RPM_BUILD_ROOT} and stick to it. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_using_buildroot_and_optflags_vs_rpm_build_root_and_rpm_opt_flags > mkdir -p $RPM_BUILD_ROOT%{_datadir}/appdata > cat > $RPM_BUILD_ROOT%{_datadir}/appdata/fillets.appdata.xml Prefer "%{_metainfodir}" over "%{_datadir}/appdata". https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
