Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnofract4d - Gnofract 4D is a Gnome-based program to draw fractals https://bugzilla.redhat.com/show_bug.cgi?id=383621 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-11-17 08:17 EST ------- For 3.6-1: * License - 3 files ------------------------------------------ lex.py yacc.py fract4dgui/FCTGen.py ------------------------------------------ makes the license of this package LGPLv2+, not BSD. * Redundant BuildRequires - Not a big issue, however some of BuildRequires are redundant * pkgconfig is needed by gtk2-devel * libpng-devel is needed by gtk2-devel * desktop-file-install - build.log says %{buildroot}%{_datadir}/gnofract4d/gnofract4d.desktop does not exist. - Category "X-Fedora" is deprecated and should not be added. * scriptlets http://fedoraproject.org/wiki/Packaging/ScriptletSnippets - scrollkeeper-updates does not seem to be needed. - mime database must be updated - desktop database must be updated as installed desktop file contains MimeType key. * %check - If some test program can be done, create %check section and write some test program with in the section (what is test.py for?) * %files entry - By the way, the two lines ------------------------------------------------- %dir %{python_sitearch}/fract4d/ %{python_sitearch}/fract4d/* ------------------------------------------------- can be replaced by one line ------------------------------------------------- %{python_sitearch}/fract4d/ ------------------------------------------------- * About non-executable-script - Non executable script should not have shebangs. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review