https://bugzilla.redhat.com/show_bug.cgi?id=1952927 Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #1 from Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> --- > Buildroot: /tmp/ne-%{version} Don't use this. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections > %install > rm -rf $RPM_BUILD_ROOT Don't do this. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections > AutoReqProv: no I've never seen this used in a Fedora package. I looked at the Fedora wiki and the only info I could found was a draft dating back to 2010. I think it should be safe to remove this. > %global debug_package %{nil} Hard "no" on this. We want debug packages in Fedora. If you need to add this, then it means that either the build is made without debuginfo, or that it's stripped somewhere during the build process. For starters, you can try calling "%set_build_flags" at the start of your %build section - this should set up CFLAGS/LDFLAGS properly. If that doesn't help, you may need to patch the Makefile. https://docs.fedoraproject.org/en-US/packaging-guidelines/Debuginfo/ > %files > %defattr(-,root,root) > /usr/bin/ne 1. %defattr should only be used when setting non-default values. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_permissions 2. Avoid hard-coded paths. Use %{_bindir} here. https://docs.fedoraproject.org/en-US/packaging-guidelines/RPMMacros/#_macros_for_paths_set_and_used_by_build_systems > %files > %{_datadir}/ne/extensions > %{_datadir}/ne/syntax/*.jsf > %{_datadir}/ne/macros/* Specifying the list like this makes the package own the files, but not the directories themselves. https://docs.fedoraproject.org/en-US/packaging-guidelines/UnownedDirectories/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
