Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: qct - Multi-vcs GUI commit tool https://bugzilla.redhat.com/show_bug.cgi?id=373621 ------- Additional Comments From david@xxxxxxxxxxxxx 2007-11-17 04:54 EST ------- == Good == Odd noarch vs. building arch specific stuff is gone Permissions correct .desktop file no present correct cleaning on %install == Minor == adding X-Fedora to the .desktop file is considered cruft * Nuke it from orbit, the only way to be sure rpmlint complains: qct.src: W: mixed-use-of-spaces-and-tabs (spaces: line 39, tab: line 3) * minor but for consistency please fix this. qct-mercurial.x86_64: W: no-documentation * minor, unsure, you might want to consider putting the correct README file in this package. qct-mercurial.x86_64: W: non-conffile-in-etc /etc/mercurial/hgrc.d/qct.rc * ignore qct.x86_64: E: no-binary * ignore == Bad == rpmlint complains: qct-debuginfo.x86_64: E: empty-debuginfo-package * if you are not generating debug symbols then add: %define debug_package %{nil} to the top of your spec to disable building -debuginfo So nothing major left, just one more rev for good measure to fix the last few minor problems. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review