https://bugzilla.redhat.com/show_bug.cgi?id=1947685 Jerry James <loganjerry@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #8 from Jerry James <loganjerry@xxxxxxxxx> --- (In reply to Michel Alexandre Salim from comment #6) > per a comment in the issue, "We should indeed generate no META and no > dune-package file" so I can just exclude the files, right? Given that the > issue is over a year old I'd rather not just assume the files will be gone > eventually :). I'll reference the issue when excluding the files, thanks Sure, that seems fine. (In reply to Michel Alexandre Salim from comment #7) > I ended up creating one (or two if -devel is needed) subpackage per OPAM > module. The scala tests are failing so I'm disabling it for now but hiding > it behind %bcond_with so we can revisit later. Ah, the problem is that there is no atds/test/argonaut_2.13-6.2.2.jar. The tests only work with scala 2.11 or 2.12, and we have 2.13 in F34 and Rawhide. If upstream will make a scala 2.13 version of that jar, the scala tests should work again. Anyway, this all looks great. This package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
