https://bugzilla.redhat.com/show_bug.cgi?id=1951909 --- Comment #2 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> --- Thanks very much! (In reply to Robert-André Mauchin 🐧 from comment #1) > - devel depends on main package so it is not necessary to reinclude the > license here: > > %files devel > %license COPYING COPYING.LESSER Corrected. > > - Did you ask upstream to add a soname? > > # Set a shared object version (0.0.0) > Patch4: 0005-Version-soname.patch Not yet. I was waiting for the review, in case we needed to make any more tweaks. I'll start sending these patches upstream now. I'll update the soname version to whatever upstream decides (if they do, otherwise we stick to 0.0.0). > > - Remember that you have > > ExcludeArch: %{ix86} %{arm32} > > in highfive so the package won't build on these arches too. > Ah, yes! I'll add the ExludeArch to this package and note the bug too. Thanks again. Updated spec/srpm: Spec URL: https://ankursinha.fedorapeople.org/morphio/morphio.spec SRPM URL: https://ankursinha.fedorapeople.org/morphio/morphio-3.0.2-1.fc34.src.rpm Latest changes: ``` $ git diff HEAD^..HEAD diff --git a/morphio.spec b/morphio.spec index 8704561..4ec4a09 100644 --- a/morphio.spec +++ b/morphio.spec @@ -98,6 +98,11 @@ BuildRequires: gsl-lite-devel BuildRequires: hdf5-devel BuildRequires: highfive-devel +# highfive Does not build on 32 bit architectures, so this package cannot build +# on them either +# Issue filed upstream: https://github.com/BlueBrain/HighFive/issues/443 +# https://bugzilla.redhat.com/show_bug.cgi?id=1952348 +ExcludeArch: %{ix86} %{arm32} %description %_description @@ -237,7 +242,6 @@ PYTHONPATH=$PYTHONPATH:$RPM_BUILD_ROOT/%{python3_sitelib}:$RPM_BUILD_ROOT/%{pyth %{_libdir}/libmorphio.so.0.0.0 %files devel -%license COPYING COPYING.LESSER %doc CHANGLOG.md CONTRIBUTING.md README.rst %{_includedir}/%{name} %{_libdir}/libmorphio.so @@ -256,6 +260,10 @@ PYTHONPATH=$PYTHONPATH:$RPM_BUILD_ROOT/%{python3_sitelib}:$RPM_BUILD_ROOT/%{pyth %endif %changelog +* Thu Apr 22 2021 Ankur Sinha <ankursinha AT fedoraproject DOT org> - 3.0.2-1 +- Add excludearch because of highfive +- do not carry licenses in devel package, since it depends on the main package already + * Wed Apr 21 2021 Ankur Sinha <ankursinha AT fedoraproject DOT org> - 3.0.2-1 - Enable tests ``` Requesting SCM now. Cheers, Ankur -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
