https://bugzilla.redhat.com/show_bug.cgi?id=1949633 Karolina Surma <ksurma@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ --- Comment #3 from Karolina Surma <ksurma@xxxxxxxxxx> --- Looks good to me. Small nitpicks (which don't prevent package approval): - When you use macro in URL, it's a bit more complicated to get to the source code. It'd be better to be able to copy&paste the URL directly. - The address in Source0 is valid but you may be interested in a more readable way to write it: https://github.com/wong2/%{pypi_name}/archive/v%{version}/%{pypi_name}-%{version}.tar.gz Package APPROVED. Please note you still need a sponsor to proceed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure