[Bug 1912120] Review Request: imhex - Hex editor for reverse engineering

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1912120

Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?(fedora@xxxxxxxxxx
                   |                            |)



--- Comment #4 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> ---
RPATH is a path for finding shared libraries, hard-coded into the executable
instead of picked up from the environment. We usually have to remove these or
prevent their creation in Fedora, but they can be acceptable for internal
libraries like plugins
(https://docs.fedoraproject.org/en-US/packaging-guidelines/#_rpath_for_internal_libraries),
which at a glance is likely the case here. However, the build is setting RPATHs
that are totally wrong, since they refer to the build environment. They will
probably need to be adjusted with chrpath.

I can probably help you figure out how to deal with the RPATH issues, if you
are willing to work through them along with correctly dealing with the bundled
dependencies, writing the desktop/AppData files, and any other issues. For
example, based on the README at https://github.com/WerWolv/ImHex#linux, there
are likely a lot more files that need to be manually installed.

On the other hand, if you are having second thoughts and don’t want to finish
the work needed for this package, you can say so and close this bug as WONTFIX,
and that’s just fine too.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux