Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kdebase-runtime - K Desktop Environment - Runtime https://bugzilla.redhat.com/show_bug.cgi?id=374531 ------- Additional Comments From kevin@xxxxxxxxxxxxxxxx 2007-11-16 19:39 EST ------- Created an attachment (id=262031) --> (https://bugzilla.redhat.com/attachment.cgi?id=262031&action=view) Diff from the current kdebase4 specfile I've done a diff between the already approved kdebase4 and the current kdebase-runtime. With these as the only changes, do I really have to reverify the entire checklist? Just one comment, about this hunk: -# needed for phonon-xine VideoWidget, also need xine-lib built with libxcb support -%if 0%{?fedora} >= 8 -BuildRequires: libxcb-devel -%endif +# phonon-xine VideoWidget need xine-lib built with libxcb support +BuildRequires: xine-lib-devel libxcb-devel What about F7? libxcb is still not available in F7. :-( Moreover, your xine-lib-devel BR is duplicated now, there's one just above those lines which you haven't removed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review